From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, bvanassche@acm.org,
axboe@kernel.dk
Subject: Re: [PATCH 1/5] null_blk: create a helper for throttling
Date: Mon, 1 Jul 2019 08:22:41 +0200 [thread overview]
Message-ID: <20190701062241.GF20073@lst.de> (raw)
In-Reply-To: <20190629050442.8459-2-chaitanya.kulkarni@wdc.com>
> + if (!test_bit(NULLB_DEV_FL_THROTTLED, &dev->flags))
> + goto out;
Maybe keep this check in the caller to make it more obvious
when it actually does something?
next prev parent reply other threads:[~2019-07-01 6:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 5:04 [PATCH 0/5] null_blk: simplify null_handle_cmd() Chaitanya Kulkarni
2019-06-29 5:04 ` [PATCH 1/5] null_blk: create a helper for throttling Chaitanya Kulkarni
2019-07-01 6:22 ` Christoph Hellwig [this message]
2019-06-29 5:04 ` [PATCH 2/5] null_blk: create a helper for badblocks Chaitanya Kulkarni
2019-07-01 6:29 ` Christoph Hellwig
2019-06-29 5:04 ` [PATCH 3/5] null_blk: create a helper for mem-backed ops Chaitanya Kulkarni
2019-06-29 5:04 ` [PATCH 4/5] null_blk: create a helper for zoned devices Chaitanya Kulkarni
2019-07-01 6:30 ` Christoph Hellwig
2019-06-29 5:04 ` [PATCH 5/5] null_blk: create a helper for req completion Chaitanya Kulkarni
2019-07-01 6:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701062241.GF20073@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.