From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, brouer@redhat.com,
Robert Olsson <robert@herjulf.net>,
Jean Hsiao <jhsiao@redhat.com>
Subject: Re: [PATCH 2/2] samples: pktgen: allow to specify destination port
Date: Mon, 1 Jul 2019 17:08:19 +0200 [thread overview]
Message-ID: <20190701170819.548a7457@carbon> (raw)
In-Reply-To: <20190629133358.8251-2-danieltimlee@gmail.com>
On Sat, 29 Jun 2019 22:33:58 +0900
"Daniel T. Lee" <danieltimlee@gmail.com> wrote:
> Currently, kernel pktgen has the feature to specify udp destination port
> for sending packet. (e.g. pgset "udp_dst_min 9")
>
> But on samples, each of the scripts doesn't have any option to achieve this.
>
> This commit adds the DST_PORT option to specify the target port(s) in the script.
>
> -p : ($DST_PORT) destination PORT range (e.g. 433-444) is also allowed
>
> Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
Nice feature, this look very usable for testing. I think my QA asked
me for something similar.
One nitpick is that script named pktgen_sample03_burst_single_flow.sh
implies this is a single flow, but by specifying a port-range this will
be more flows. I'm okay with adding this, as the end-user specifying a
port-range should realize this. Thus, you get my ACK.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Another thing you should realize (but you/we cannot do anything about)
is that when the scripts use burst or clone, then the port (UDPDST_RND)
will be the same for all packets in the same burst. I don't know if it
matters for your use-case.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-07-01 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 13:33 [PATCH 1/2] samples: pktgen: add some helper functions for port parsing Daniel T. Lee
2019-06-29 13:33 ` [PATCH 2/2] samples: pktgen: allow to specify destination port Daniel T. Lee
2019-07-01 15:08 ` Jesper Dangaard Brouer [this message]
2019-07-01 20:01 ` Daniel T. Lee
2019-07-01 18:02 ` David Miller
2019-07-01 14:51 ` [PATCH 1/2] samples: pktgen: add some helper functions for port parsing Jesper Dangaard Brouer
2019-07-01 18:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701170819.548a7457@carbon \
--to=brouer@redhat.com \
--cc=danieltimlee@gmail.com \
--cc=davem@davemloft.net \
--cc=jhsiao@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robert@herjulf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.