All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30
Date: Tue, 2 Jul 2019 21:00:43 +0800	[thread overview]
Message-ID: <20190702130043.GA86373@intel.com> (raw)
In-Reply-To: <1561459083-29808-1-git-send-email-haiyue.wang@intel.com>

On 06/25, Haiyue Wang wrote:
>Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB,
>otherwise, the pop 'arg' in 'parse_int' holds wrong data like 'arg->
>offset = 5912737, arg->size = 0', this caused the parse failure.
>
>If calling like 'push_args(ctx, ARGS_ENTRY_ARB..)', the below code for
>assgining 'offset & size' will be missed for some gcc optimization.
>
>parse_vc_action_rss_queue
>    29c5:	c5 f9 ef c0          	vpxor  %xmm0,%xmm0,%xmm0
>    29c9:	43 8d 44 24 68       	lea    0x68(%r12,%r12,1),%eax
>    29ce:	48 c7 44 24 20 00 00 	movq   $0x0,0x20(%rsp)
>    29d5:	00 00
>    29d7:	c5 f8 29 44 24 10    	vmovaps %xmm0,0x10(%rsp)
>    29dd:	89 44 24 18          	mov    %eax,0x18(%rsp)
>    29e1:	48 63 83 0c 01 00 00 	movslq 0x10c(%rbx),%rax
>    29e8:	c7 44 24 1c 02 00 00 	movl   $0x2,0x1c(%rsp)
>    29ef:	00
>    29f0:	c5 f8 29 04 24       	vmovaps %xmm0,(%rsp)
>
>The above assembly code is from this modification with:
>    gcc version 9.1.1 20190503 (Red Hat 9.1.1-1) (GCC)
>    Fedora release 30 (Thirty)
>    5.1.11-300.fc30.x86_64

Do you mean without your patch, the above assembly code (for assgining offset & size)
is missing, after apply this patch, it would show up?

>
>Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration")
>Cc: stable@dpdk.org
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---

Minor nit, better to reply the v2 to v1 and add some changelog after the `---`
mark.

> app/test-pmd/cmdline_flow.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>index 201bd9d..4a083d4 100644
>--- a/app/test-pmd/cmdline_flow.c
>+++ b/app/test-pmd/cmdline_flow.c
>@@ -3378,6 +3378,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token,
> {
> 	static const enum index next[] = NEXT_ENTRY(ACTION_RSS_QUEUE);
> 	struct action_rss_data *action_rss_data;
>+	const struct arg *arg;
> 	int ret;
> 	int i;
> 
>@@ -3393,10 +3394,10 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token,
> 	}
> 	if (i >= ACTION_RSS_QUEUE_NUM)
> 		return -1;
>-	if (push_args(ctx,
>-		      ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) +
>-				     i * sizeof(action_rss_data->queue[i]),
>-				     sizeof(action_rss_data->queue[i]))))
>+	arg = ARGS_ENTRY_ARB(offsetof(struct action_rss_data, queue) +
>+			     i * sizeof(action_rss_data->queue[i]),
>+			     sizeof(action_rss_data->queue[i]));
>+	if (push_args(ctx, arg))
> 		return -1;
> 	ret = parse_int(ctx, token, str, len, NULL, 0);
> 	if (ret < 0) {

For the patch, Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Thanks,
Xiaolong

>-- 
>2.7.4
>

  reply	other threads:[~2019-07-02  6:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 10:38 [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30 Haiyue Wang
2019-07-02 13:00 ` Ye Xiaolong [this message]
2019-07-02  6:21   ` Wang, Haiyue
2019-07-03 15:23     ` Iremonger, Bernard
2019-07-04 23:01       ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190702130043.GA86373@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.