All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Christoph Hellwig <hch@infradead.org>,
	Ming Lei <ming.lei@redhat.com>, Hannes Reinecke <hare@suse.com>,
	Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH 2/2] blk-mq: Simplify blk_mq_make_request()
Date: Tue, 2 Jul 2019 15:26:12 +0200	[thread overview]
Message-ID: <20190702132612.GC15798@lst.de> (raw)
In-Reply-To: <20190701154730.203795-3-bvanassche@acm.org>

On Mon, Jul 01, 2019 at 08:47:30AM -0700, Bart Van Assche wrote:
> Move the blk_mq_bio_to_request() call in front of the if-statement.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2019-07-02 13:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01 15:47 [PATCH, RESEND 0/2] Simplify blk-mq implementation Bart Van Assche
2019-07-01 15:47 ` [PATCH 1/2] blk-mq: Remove blk_mq_put_ctx() Bart Van Assche
2019-07-02 13:25   ` Christoph Hellwig
2019-07-02 13:25     ` Christoph Hellwig
2019-07-03  2:45   ` Ming Lei
2019-07-03 15:06     ` Bart Van Assche
2019-07-01 15:47 ` [PATCH 2/2] blk-mq: Simplify blk_mq_make_request() Bart Van Assche
2019-07-02 13:26   ` Christoph Hellwig [this message]
2019-07-02 23:42   ` Minwoo Im
2019-07-03  2:46   ` Ming Lei
2019-07-03  2:34 ` [PATCH, RESEND 0/2] Simplify blk-mq implementation Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2019-06-04 18:17 [PATCH " Bart Van Assche
2019-06-04 18:17 ` [PATCH 2/2] blk-mq: Simplify blk_mq_make_request() Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190702132612.GC15798@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.