From: Pengfei Li <lpf.vector@gmail.com>
To: akpm@linux-foundation.org, peterz@infradead.org, urezki@gmail.com
Cc: rpenyaev@suse.de, mhocko@suse.com, guro@fb.com,
aryabinin@virtuozzo.com, rppt@linux.ibm.com, mingo@kernel.org,
rick.p.edgecombe@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Pengfei Li <lpf.vector@gmail.com>
Subject: [PATCH v2 1/5] mm/vmalloc.c: Introduce a wrapper function of insert_vmap_area()
Date: Tue, 2 Jul 2019 22:15:37 +0800 [thread overview]
Message-ID: <20190702141541.12635-2-lpf.vector@gmail.com> (raw)
In-Reply-To: <20190702141541.12635-1-lpf.vector@gmail.com>
The red-black tree whose root is vmap_area_root is called the
*BUSY* tree. Since function insert_vmap_area() is only used to
add vmap area to the *BUSY* tree, so add wrapper functions
insert_va_to_busy_tree for readability.
Besides, rename insert_vmap_area to __insert_vmap_area to indicate
that it should not be called directly.
Signed-off-by: Pengfei Li <lpf.vector@gmail.com>
---
mm/vmalloc.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 0f76cca32a1c..0a46be76c63b 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -641,7 +641,7 @@ augment_tree_propagate_from(struct vmap_area *va)
}
static void
-insert_vmap_area(struct vmap_area *va,
+__insert_vmap_area(struct vmap_area *va,
struct rb_root *root, struct list_head *head)
{
struct rb_node **link;
@@ -651,6 +651,12 @@ insert_vmap_area(struct vmap_area *va,
link_va(va, root, parent, link, head);
}
+static __always_inline void
+insert_va_to_busy_tree(struct vmap_area *va)
+{
+ __insert_vmap_area(va, &vmap_area_root, &vmap_area_list);
+}
+
static void
insert_vmap_area_augment(struct vmap_area *va,
struct rb_node *from, struct rb_root *root,
@@ -1070,7 +1076,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
va->va_start = addr;
va->va_end = addr + size;
va->flags = 0;
- insert_vmap_area(va, &vmap_area_root, &vmap_area_list);
+ insert_va_to_busy_tree(va);
spin_unlock(&vmap_area_lock);
@@ -1871,7 +1877,7 @@ void __init vmalloc_init(void)
va->va_start = (unsigned long)tmp->addr;
va->va_end = va->va_start + tmp->size;
va->vm = tmp;
- insert_vmap_area(va, &vmap_area_root, &vmap_area_list);
+ insert_va_to_busy_tree(va);
}
/*
@@ -3281,7 +3287,7 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets,
va->va_start = start;
va->va_end = start + size;
- insert_vmap_area(va, &vmap_area_root, &vmap_area_list);
+ insert_va_to_busy_tree(va);
}
spin_unlock(&vmap_area_lock);
--
2.21.0
next prev parent reply other threads:[~2019-07-02 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 14:15 [PATCH v2 0/5] mm/vmalloc.c: improve readability and rewrite vmap_area Pengfei Li
2019-07-02 14:15 ` Pengfei Li [this message]
2019-07-02 14:15 ` [PATCH v2 2/5] mm/vmalloc.c: Introduce a wrapper function of insert_vmap_area_augment() Pengfei Li
2019-07-02 14:15 ` [PATCH v2 3/5] mm/vmalloc.c: Rename function __find_vmap_area() for readability Pengfei Li
2019-07-02 14:15 ` [PATCH v2 4/5] mm/vmalloc.c: Modify function merge_or_add_vmap_area() " Pengfei Li
2019-07-02 14:15 ` [PATCH v2 5/5] mm/vmalloc.c: Rewrite struct vmap_area to reduce its size Pengfei Li
2019-07-03 19:30 ` [PATCH v2 0/5] mm/vmalloc.c: improve readability and rewrite vmap_area Uladzislau Rezki
2019-07-04 9:31 ` Pengfei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702141541.12635-2-lpf.vector@gmail.com \
--to=lpf.vector@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rpenyaev@suse.de \
--cc=rppt@linux.ibm.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.