From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata() Date: Tue, 2 Jul 2019 14:32:25 +0200 Message-ID: <20190702143225.12b0fe07@karo-electronics.de> References: <20190701032342.25971-1-huangfq.daxian@gmail.com> <20190701075255.GD172968@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fuqian Huang Cc: Kate Stewart , Tony Lindgren , Richard Fontana , Laxman Dewangan , Lee Jones , Rob Herring , Florian Fainelli , Anson Huang , Fabio Estevam , Jonathan Hunter , Luca Weiss , Andy Shevchenko , NXP Linux Team , linux-input , Dan Carpenter , Brian Masney , Arnd Bergmann , Sascha Hauer , Sylvain Lemieux , Vladimir Zapolskiy , Alexios Zavras , linux-tegra@vger.kernel.org, Thomas Gleixner List-Id: linux-input@vger.kernel.org SGksCgpPbiBUdWUsIDIgSnVsIDIwMTkgMTk6NDc6MTYgKzA4MDAgRnVxaWFuIEh1YW5nIHdyb3Rl Ogo+IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4g5pa8IDIwMTnl ubQ35pyIMuaXpemAseS6jCDkuIvljYg1OjUx5a+r6YGT77yaCj4gPgo+ID4gT24gVHVlLCBKdWwg MiwgMjAxOSBhdCAxMToyMCBBTSBGdXFpYW4gSHVhbmcgPGh1YW5nZnEuZGF4aWFuQGdtYWlsLmNv bT4gd3JvdGU6ICAKPiA+ID4KPiA+ID4gSSBhbSBub3QgYW4gZXhwZXJ0IG9uIHRoaXMuIEkganVz dCB3cml0ZSBhIGNvY2NpbmVsbGUgc2NyaXB0IHRvIHNlYXJjaAo+ID4gPiB0aGlzIGtpbmQgb2Yg bWlzdXNlIGFuZCBmaXggaXQgaW4gYSBuYWl2ZSB3YXkuCj4gPiA+IENvdWxkIHlvdSB0ZWxsIG1l IGFib3V0IGhvdyB0byB1c2UgdGhlIHByb3BlciBidXMgYWNjZXNzb3JzPyBUaGVuIEkKPiA+ID4g d2lsbCBmaXggaXQgdXAgYW5kIHJlc2VuZCBhIHYyIHBhdGNoIHNldC4gIAo+ID4KPiA+IEZpcnN0 LCBkb24ndCB0b3AgcG9zdC4KPiA+IEFuZCBhbnN3ZXJpbmcgdG8gdGhpcywgc2ltcGxlIGRyb3Ag dGhlIHBhdGNoLgo+ID4gUHJvcGVyIGJ1cyBhY2Nlc3NvcnMgaXMgZXhhY3RseSB3aGF0IGl0J3Mg dXNlZCBpbiB0aGUgY3VycmVudCBjb2RlLiAgCj4gCj4gQnV0IHdoeSBub3QgdXNlIGRldl9nZXRf ZHJ2ZGF0YSBkaXJlY3RseS4KPiBJdCBzaW1wbGlmaWVzIGdldHRpbmcgdGhlICdkcml2ZXJfZGF0 YScgZnJvbSAnc3RydWN0IGRldmljZScgZGlyZWN0bHkuCj4gQW5kIHRoZSBwbGF0Zm9ybV9kZXZp Y2UgaGVyZSBpcyBub3QgcmVxdWlyZWQuCj4gUmVwbGFjZSBpdCBjYW4gcmVtb3ZlIHRoZSB1bm5l Y2Vzc2FyeSBzdGVwIGJhY2sgYW5kIGZvcnRoLiAoZGV2IC0+IHBkZXYgLT4gZGV2KS4KPiAKRGlk IHlvdSBjaGVjayB3aGV0aGVyIHRoZSBjb21waWxlciBnZW5lcmF0ZXMgZGlmZmVyZW50IChiZXR0 ZXIpIGNvZGUKd2l0aCBhbmQgd2l0aG91dCB5b3VyIHBhdGNoPyBNeSBndWVzcyBpcyBpdCB3b24n dC4KCgpMb3RoYXIgV2HDn21hbm4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FCDC06510 for ; Tue, 2 Jul 2019 12:32:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ADB221721 for ; Tue, 2 Jul 2019 12:32:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="byaU5Q0I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ADB221721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wMmKbVgIWqIalUOVzFzRiGXDuEGTBbYhgMP0ZKrKJLM=; b=byaU5Q0IW6T1nA oXSogT3+JOIFVJPGSfRINxNK5twcjcP+UTdkmPxdAL9DwdZ3M8DYLfPl8Hqb8ogSpXeQG0+C87Ghy p3094+rSEB0PJrL8l5S1sovWcBZhZEdu/DLUU19aO6XTL4LWFuehx/1+AESWT8vV5Y8PC3WRjeh/D 5xDuahOS4BuY94vmT8XmLHffdytX3OOOcQ/KC3CvnYcoQ4Ut57JnynznyNEfzDg6hyccrHjhGwVlW kzC1UJryWOVoGDm3jPCaP9g63ktHj9o6b2IvwLVCBhzKleqQ/+7AhsqHbU9HsFKZiLb+lX49mjmlW 1L0VetqZ0PHZLdBxZqrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiHxr-0005eH-5Y; Tue, 02 Jul 2019 12:32:51 +0000 Received: from mailout02.agenturserver.de ([185.15.192.33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiHxm-0005cw-3Y for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2019 12:32:48 +0000 Received: from mail02.agenturserver.de (mail02.internal [172.16.51.35]) by mailout02.agenturserver.de (Postfix) with ESMTP id 64F3112614C; Tue, 2 Jul 2019 14:32:38 +0200 (CEST) Received: from localhost (ac02.internal [172.16.51.82]) by mail02.agenturserver.de (Postfix) with ESMTP id 1818180753; Tue, 2 Jul 2019 14:32:37 +0200 (CEST) Received: from mail.agenturserver.de ([172.16.51.35]) by localhost (ac02.mittwald.de [172.16.51.82]) (amavisd-new, port 10026) with ESMTP id wKItvphULAwB; Tue, 2 Jul 2019 14:32:36 +0200 (CEST) Received: from karo-electronics.de (unknown [89.1.81.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lw@karo-electronics.de) by mail.agenturserver.de (Postfix) with ESMTPSA; Tue, 2 Jul 2019 14:32:26 +0200 (CEST) Date: Tue, 2 Jul 2019 14:32:25 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Fuqian Huang Subject: Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata() Message-ID: <20190702143225.12b0fe07@karo-electronics.de> In-Reply-To: References: <20190701032342.25971-1-huangfq.daxian@gmail.com> <20190701075255.GD172968@dtor-ws> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190702_053246_311121_22023BB4 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Tony Lindgren , Richard Fontana , Laxman Dewangan , Lee Jones , Rob Herring , Florian Fainelli , Anson Huang , Fabio Estevam , Jonathan Hunter , Luca Weiss , Andy Shevchenko , NXP Linux Team , linux-input , Dan Carpenter , Brian Masney , Arnd Bergmann , Sascha Hauer , Sylvain Lemieux , Vladimir Zapolskiy , Alexios Zavras , linux-tegra@vger.kernel.org, Thomas Gleixner , Andy Shevchenko , Allison Randal , linux-arm Mailing List , Enrico Weigelt , Pascal PAILLET-LME , Greg Kroah-Hartman , Dmitry Torokhov , Linux Kernel Mailing List , H Hartley Sweeten , Thierry Reding , Pengutronix Kernel Team , Olof Johansson , Christian Hoff , Shawn Guo , Gabriel Fernandez Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUdWUsIDIgSnVsIDIwMTkgMTk6NDc6MTYgKzA4MDAgRnVxaWFuIEh1YW5nIHdyb3Rl Ogo+IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWlsLmNvbT4g5pa8IDIwMTnl ubQ35pyIMuaXpemAseS6jCDkuIvljYg1OjUx5a+r6YGT77yaCj4gPgo+ID4gT24gVHVlLCBKdWwg MiwgMjAxOSBhdCAxMToyMCBBTSBGdXFpYW4gSHVhbmcgPGh1YW5nZnEuZGF4aWFuQGdtYWlsLmNv bT4gd3JvdGU6ICAKPiA+ID4KPiA+ID4gSSBhbSBub3QgYW4gZXhwZXJ0IG9uIHRoaXMuIEkganVz dCB3cml0ZSBhIGNvY2NpbmVsbGUgc2NyaXB0IHRvIHNlYXJjaAo+ID4gPiB0aGlzIGtpbmQgb2Yg bWlzdXNlIGFuZCBmaXggaXQgaW4gYSBuYWl2ZSB3YXkuCj4gPiA+IENvdWxkIHlvdSB0ZWxsIG1l IGFib3V0IGhvdyB0byB1c2UgdGhlIHByb3BlciBidXMgYWNjZXNzb3JzPyBUaGVuIEkKPiA+ID4g d2lsbCBmaXggaXQgdXAgYW5kIHJlc2VuZCBhIHYyIHBhdGNoIHNldC4gIAo+ID4KPiA+IEZpcnN0 LCBkb24ndCB0b3AgcG9zdC4KPiA+IEFuZCBhbnN3ZXJpbmcgdG8gdGhpcywgc2ltcGxlIGRyb3Ag dGhlIHBhdGNoLgo+ID4gUHJvcGVyIGJ1cyBhY2Nlc3NvcnMgaXMgZXhhY3RseSB3aGF0IGl0J3Mg dXNlZCBpbiB0aGUgY3VycmVudCBjb2RlLiAgCj4gCj4gQnV0IHdoeSBub3QgdXNlIGRldl9nZXRf ZHJ2ZGF0YSBkaXJlY3RseS4KPiBJdCBzaW1wbGlmaWVzIGdldHRpbmcgdGhlICdkcml2ZXJfZGF0 YScgZnJvbSAnc3RydWN0IGRldmljZScgZGlyZWN0bHkuCj4gQW5kIHRoZSBwbGF0Zm9ybV9kZXZp Y2UgaGVyZSBpcyBub3QgcmVxdWlyZWQuCj4gUmVwbGFjZSBpdCBjYW4gcmVtb3ZlIHRoZSB1bm5l Y2Vzc2FyeSBzdGVwIGJhY2sgYW5kIGZvcnRoLiAoZGV2IC0+IHBkZXYgLT4gZGV2KS4KPiAKRGlk IHlvdSBjaGVjayB3aGV0aGVyIHRoZSBjb21waWxlciBnZW5lcmF0ZXMgZGlmZmVyZW50IChiZXR0 ZXIpIGNvZGUKd2l0aCBhbmQgd2l0aG91dCB5b3VyIHBhdGNoPyBNeSBndWVzcyBpcyBpdCB3b24n dC4KCgpMb3RoYXIgV2HDn21hbm4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D02C06510 for ; Tue, 2 Jul 2019 12:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73990208C4 for ; Tue, 2 Jul 2019 12:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbfGBMjd convert rfc822-to-8bit (ORCPT ); Tue, 2 Jul 2019 08:39:33 -0400 Received: from mailout02.agenturserver.de ([185.15.192.33]:38720 "EHLO mailout02.agenturserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbfGBMjd (ORCPT ); Tue, 2 Jul 2019 08:39:33 -0400 X-Greylist: delayed 409 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Jul 2019 08:39:30 EDT Received: from mail02.agenturserver.de (mail02.internal [172.16.51.35]) by mailout02.agenturserver.de (Postfix) with ESMTP id 64F3112614C; Tue, 2 Jul 2019 14:32:38 +0200 (CEST) Received: from localhost (ac02.internal [172.16.51.82]) by mail02.agenturserver.de (Postfix) with ESMTP id 1818180753; Tue, 2 Jul 2019 14:32:37 +0200 (CEST) Received: from mail.agenturserver.de ([172.16.51.35]) by localhost (ac02.mittwald.de [172.16.51.82]) (amavisd-new, port 10026) with ESMTP id wKItvphULAwB; Tue, 2 Jul 2019 14:32:36 +0200 (CEST) Received: from karo-electronics.de (unknown [89.1.81.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lw@karo-electronics.de) by mail.agenturserver.de (Postfix) with ESMTPSA; Tue, 2 Jul 2019 14:32:26 +0200 (CEST) Date: Tue, 2 Jul 2019 14:32:25 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Fuqian Huang Cc: Andy Shevchenko , Kate Stewart , Tony Lindgren , Richard Fontana , Laxman Dewangan , Fabio Estevam , Rob Herring , Florian Fainelli , Anson Huang , Lee Jones , Jonathan Hunter , Luca Weiss , NXP Linux Team , Sylvain Lemieux , Dan Carpenter , Brian Masney , Arnd Bergmann , Sascha Hauer , linux-input , Vladimir Zapolskiy , Alexios Zavras , linux-tegra@vger.kernel.org, Thomas Gleixner , Andy Shevchenko , Allison Randal , linux-arm Mailing List , Pascal PAILLET-LME , Shawn Guo , Dmitry Torokhov , Linux Kernel Mailing List , H Hartley Sweeten , Thierry Reding , Pengutronix Kernel Team , Greg Kroah-Hartman , Olof Johansson , Christian Hoff , Enrico Weigelt , Gabriel Fernandez Subject: Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata() Message-ID: <20190702143225.12b0fe07@karo-electronics.de> In-Reply-To: References: <20190701032342.25971-1-huangfq.daxian@gmail.com> <20190701075255.GD172968@dtor-ws> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, 2 Jul 2019 19:47:16 +0800 Fuqian Huang wrote: > Andy Shevchenko 於 2019年7月2日週二 下午5:51寫道： > > > > On Tue, Jul 2, 2019 at 11:20 AM Fuqian Huang wrote: > > > > > > I am not an expert on this. I just write a coccinelle script to search > > > this kind of misuse and fix it in a naive way. > > > Could you tell me about how to use the proper bus accessors? Then I > > > will fix it up and resend a v2 patch set. > > > > First, don't top post. > > And answering to this, simple drop the patch. > > Proper bus accessors is exactly what it's used in the current code. > > But why not use dev_get_drvdata directly. > It simplifies getting the 'driver_data' from 'struct device' directly. > And the platform_device here is not required. > Replace it can remove the unnecessary step back and forth. (dev -> pdev -> dev). > Did you check whether the compiler generates different (better) code with and without your patch? My guess is it won't. Lothar Waßmann