All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf tools: Fix typos / broken sentences
Date: Tue, 2 Jul 2019 12:57:31 -0300	[thread overview]
Message-ID: <20190702155731.GF15462@kernel.org> (raw)
In-Reply-To: <20190628220900.13741-1-andi@firstfloor.org>

Em Fri, Jun 28, 2019 at 03:09:00PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> - Fix a typo in the man page
> - Fix a tip that doesn't make any sense.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/Documentation/perf-report.txt | 2 +-
>  tools/perf/Documentation/tips.txt        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 8c4372819e11..987261d158d4 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -89,7 +89,7 @@ OPTIONS
>  	- socket: processor socket number the task ran at the time of sample
>  	- srcline: filename and line number executed at the time of sample.  The
>  	DWARF debugging info must be provided.
> -	- srcfile: file name of the source file of the same. Requires dwarf
> +	- srcfile: file name of the source file of the samples. Requires dwarf
>  	information.
>  	- weight: Event specific weight, e.g. memory latency or transaction
>  	abort cost. This is the global weight.
> diff --git a/tools/perf/Documentation/tips.txt b/tools/perf/Documentation/tips.txt
> index 869965d629ce..825745a645c1 100644
> --- a/tools/perf/Documentation/tips.txt
> +++ b/tools/perf/Documentation/tips.txt
> @@ -38,6 +38,6 @@ To report cacheline events from previous recording: perf c2c report
>  To browse sample contexts use perf report --sample 10 and select in context menu
>  To separate samples by time use perf report --sort time,overhead,sym
>  To set sample time separation other than 100ms with --sort time use --time-quantum
> -Add -I to perf report to sample register values visible in perf report context.
> +Add -I to perf record to sample register values, which will be visible in perf report sample context.
>  To show IPC for sampling periods use perf record -e '{cycles,instructions}:S' and then browse context
>  To show context switches in perf report sample context add --switch-events to perf record.
> -- 
> 2.20.1

-- 

- Arnaldo

  reply	other threads:[~2019-07-02 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 22:09 [PATCH] perf tools: Fix typos / broken sentences Andi Kleen
2019-07-02 15:57 ` Arnaldo Carvalho de Melo [this message]
2019-07-03 14:41 ` [tip:perf/core] " tip-bot for Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190702155731.GF15462@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.