* [PATCH] perf tools: Fix bison warnings for pure parser
@ 2019-06-27 22:20 Andi Kleen
2019-06-28 8:05 ` Jiri Olsa
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2019-06-27 22:20 UTC (permalink / raw)
To: acme; +Cc: jolsa, linux-kernel, Andi Kleen
From: Andi Kleen <ak@linux.intel.com>
bison 3.4.1 complains during a perf build:
util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
1 | %pure-parser
| ^~~~~~~~~~~~
CC /home/andi/lsrc/obj-perf/ui/browsers/map.o
util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
util/expr.y:13.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
13 | %pure-parser
| ^~~~~~~~~~~~
util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
Change the declarations to %define api.pure
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/util/expr.y | 2 +-
tools/perf/util/parse-events.y | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
index 432b8560cf51..803c0929c205 100644
--- a/tools/perf/util/expr.y
+++ b/tools/perf/util/expr.y
@@ -10,7 +10,7 @@
#define MAXIDLEN 256
%}
-%pure-parser
+%define api.pure
%parse-param { double *final_val }
%parse-param { struct parse_ctx *ctx }
%parse-param { const char **pp }
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 6ad8d4914969..4eb10c27c30f 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -1,4 +1,4 @@
-%pure-parser
+%define api.pure
%parse-param {void *_parse_state}
%parse-param {void *scanner}
%lex-param {void* scanner}
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf tools: Fix bison warnings for pure parser
2019-06-27 22:20 [PATCH] perf tools: Fix bison warnings for pure parser Andi Kleen
@ 2019-06-28 8:05 ` Jiri Olsa
2019-07-02 16:01 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Olsa @ 2019-06-28 8:05 UTC (permalink / raw)
To: Andi Kleen; +Cc: acme, jolsa, linux-kernel, Andi Kleen
On Thu, Jun 27, 2019 at 03:20:21PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> bison 3.4.1 complains during a perf build:
>
> util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> 1 | %pure-parser
> | ^~~~~~~~~~~~
> CC /home/andi/lsrc/obj-perf/ui/browsers/map.o
> util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
>
> util/expr.y:13.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> 13 | %pure-parser
> | ^~~~~~~~~~~~
> util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
>
> Change the declarations to %define api.pure
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
looks good, let's hope it'll pass Arnaldo's build test
jirka
> ---
> tools/perf/util/expr.y | 2 +-
> tools/perf/util/parse-events.y | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index 432b8560cf51..803c0929c205 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -10,7 +10,7 @@
> #define MAXIDLEN 256
> %}
>
> -%pure-parser
> +%define api.pure
> %parse-param { double *final_val }
> %parse-param { struct parse_ctx *ctx }
> %parse-param { const char **pp }
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 6ad8d4914969..4eb10c27c30f 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -1,4 +1,4 @@
> -%pure-parser
> +%define api.pure
> %parse-param {void *_parse_state}
> %parse-param {void *scanner}
> %lex-param {void* scanner}
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf tools: Fix bison warnings for pure parser
2019-06-28 8:05 ` Jiri Olsa
@ 2019-07-02 16:01 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-07-02 16:01 UTC (permalink / raw)
To: Jiri Olsa; +Cc: Andi Kleen, jolsa, linux-kernel, Andi Kleen
Em Fri, Jun 28, 2019 at 10:05:07AM +0200, Jiri Olsa escreveu:
> On Thu, Jun 27, 2019 at 03:20:21PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > bison 3.4.1 complains during a perf build:
> >
> > util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > 1 | %pure-parser
> > | ^~~~~~~~~~~~
> > CC /home/andi/lsrc/obj-perf/ui/browsers/map.o
> > util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> >
> > util/expr.y:13.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > 13 | %pure-parser
> > | ^~~~~~~~~~~~
> > util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> >
> > Change the declarations to %define api.pure
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> looks good, let's hope it'll pass Arnaldo's build test
starting the tests now...
> jirka
>
> > ---
> > tools/perf/util/expr.y | 2 +-
> > tools/perf/util/parse-events.y | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> > index 432b8560cf51..803c0929c205 100644
> > --- a/tools/perf/util/expr.y
> > +++ b/tools/perf/util/expr.y
> > @@ -10,7 +10,7 @@
> > #define MAXIDLEN 256
> > %}
> >
> > -%pure-parser
> > +%define api.pure
> > %parse-param { double *final_val }
> > %parse-param { struct parse_ctx *ctx }
> > %parse-param { const char **pp }
> > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> > index 6ad8d4914969..4eb10c27c30f 100644
> > --- a/tools/perf/util/parse-events.y
> > +++ b/tools/perf/util/parse-events.y
> > @@ -1,4 +1,4 @@
> > -%pure-parser
> > +%define api.pure
> > %parse-param {void *_parse_state}
> > %parse-param {void *scanner}
> > %lex-param {void* scanner}
> > --
> > 2.21.0
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-02 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-27 22:20 [PATCH] perf tools: Fix bison warnings for pure parser Andi Kleen
2019-06-28 8:05 ` Jiri Olsa
2019-07-02 16:01 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.