From: Jiri Benc <jbenc@redhat.com>
To: Y Song <ys114321@gmail.com>
Cc: Song Liu <liu.song.a23@gmail.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Mathieu Xhonneux <m.xhonneux@gmail.com>
Subject: Re: [PATCH bpf] selftests: bpf: fix inlines in test_lwt_seg6local
Date: Tue, 2 Jul 2019 19:29:53 +0200 [thread overview]
Message-ID: <20190702192953.3fa9ccb5@redhat.com> (raw)
In-Reply-To: <CAH3MdRUbkswKAYiDSmhe9cdd-Jd=YmC0_PSLhzfY7vKv-zxCCA@mail.gmail.com>
On Mon, 1 Jul 2019 11:39:27 -0700, Y Song wrote:
> By default, we have
> # define __always_inline inline __attribute__((always_inline))
>
> So just use __always_inline should be less verbose in your patch.
I'll resubmit, converting everything to __always_inline, targeting
bpf-next.
> BTW, what compiler did you use have this behavior?
clang version 7.0.1 (tags/RELEASE_701/final)
LLVM version 7.0.1
> Did you have issues with `static __attribute__((always_inline))`?
That seems to work, too.
Jiri
prev parent reply other threads:[~2019-07-02 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 14:43 [PATCH bpf] selftests: bpf: fix inlines in test_lwt_seg6local Jiri Benc
2019-06-29 18:04 ` Song Liu
2019-06-29 18:04 ` Song Liu
2019-07-01 8:12 ` Jiri Benc
2019-07-01 18:39 ` Y Song
2019-07-02 17:29 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702192953.3fa9ccb5@redhat.com \
--to=jbenc@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=liu.song.a23@gmail.com \
--cc=m.xhonneux@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ys114321@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.