From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
lgirdwood@gmail.com, vkoul@kernel.org, robh+dt@kernel.org,
srini@kernel.org
Subject: Re: [PATCH 2/6] ASoC: wcd934x: add support to wcd9340/wcd9341 codec
Date: Wed, 3 Jul 2019 12:52:43 +0100 [thread overview]
Message-ID: <20190703115243.GV2793@sirena.org.uk> (raw)
In-Reply-To: <0a9a994c-5a88-539f-3af0-76754b9b58d1@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 1557 bytes --]
On Wed, Jul 03, 2019 at 09:49:37AM +0100, Srinivas Kandagatla wrote:
> On 02/07/2019 17:57, Mark Brown wrote:
> > This is a driver for a single device, you should be able to
> > instantiate things without requiring binding through DT (and
> > hence support non-DT systems such as those using ACPI).
> My view point atleast from hw side was that Codec is Parent which is
> encompassing these different blocks and bus interface. DT representation
> clearly showed that relationship between the parent and child devices.
> Binding it through DT will make sure that resources are ready before
> they are instantiated.
> All the child devices also have some machine/board specific properties
> and dependency on resources from parent like regmap, clks, and bus.
> In ACPI case, am not 100% sure how these will be represented inline with
> hw representation.
> Are you suggesting to use MFD here?
I'm saying that you should be using a MFD here like all the other
CODECs with multiple functions and that you shouldn't have
compatible strings in DT for the subfunctions since you already
know they'll be there simply from enumerating the chip as a whole
and how exactly they are divided up is a function of how Linux
currently has subsystems, not of the hardware.
> > > This will instantiate all the child devices like pinctrl, SoundWire
> > > Controller and so on.
> > Just create platform devices like normal...
> These are already modeled as platform devices, except the fact that
> these are children of Codec device.
No, you've got them as DT nodes.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2019-07-03 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 8:09 [PATCH 0/6] ASoC: Add support to WCD9340/WCD9341 codec Srinivas Kandagatla
2019-07-02 8:09 ` [PATCH 1/6] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec Srinivas Kandagatla
2019-07-02 14:02 ` Mark Brown
2019-07-02 16:36 ` Srinivas Kandagatla
2019-07-22 22:55 ` Rob Herring
2019-07-22 22:59 ` Rob Herring
2019-07-02 8:09 ` [PATCH 2/6] ASoC: wcd934x: add support to wcd9340/wcd9341 codec Srinivas Kandagatla
2019-07-02 14:44 ` Mark Brown
2019-07-02 16:37 ` Srinivas Kandagatla
2019-07-02 16:57 ` Mark Brown
2019-07-03 8:49 ` Srinivas Kandagatla
2019-07-03 11:52 ` Mark Brown [this message]
2019-07-03 12:06 ` Srinivas Kandagatla
2019-07-02 8:09 ` [PATCH 3/6] ASoC: wcd934x: add basic controls Srinivas Kandagatla
2019-07-02 8:09 ` [PATCH 4/6] ASoC: wcd934x: add playback dapm widgets Srinivas Kandagatla
2019-07-02 8:09 ` [PATCH 5/6] ASoC: wcd934x: add capture " Srinivas Kandagatla
2019-07-02 8:09 ` [PATCH 6/6] ASoC: wcd934x: add audio routings Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703115243.GV2793@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.