From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Matias Bjorling <mb@lightnvm.io>,
linux-block@vger.kernel.org
Subject: Re: remove bi_phys_segments and related cleanups
Date: Wed, 3 Jul 2019 14:16:08 +0200 [thread overview]
Message-ID: <20190703121608.GC7671@lst.de> (raw)
In-Reply-To: <20190703013536.GA31366@lst.de>
On Wed, Jul 03, 2019 at 03:35:36AM +0200, Christoph Hellwig wrote:
> I didn't run with online discard, but I tried FITRIM (with XFS).
>
> I'll try looking into ext4. I remember we had some weird one offs in that
> area for the different ways the physical segments are calculated, so this
> makes sense. Off to dinner now, but I'll look into it tomorrow.
ext4 reproduced the bug instantly, but it was Write Zeroes, not Discard.
Which explains the whole thing as ext4 is the only major user of Write
Zeroes. A oatch will be on its way shortly.
prev parent reply other threads:[~2019-07-03 12:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 10:28 remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-06 10:28 ` [PATCH 1/6] block: initialize the write priority in blk_rq_bio_prep Christoph Hellwig
2019-06-07 5:58 ` Hannes Reinecke
2019-06-07 12:20 ` Minwoo Im
2019-06-20 13:40 ` Minwoo Im
2019-06-06 10:29 ` [PATCH 2/6] block: remove blk_init_request_from_bio Christoph Hellwig
2019-06-07 5:59 ` Hannes Reinecke
2019-06-07 12:23 ` Minwoo Im
2019-06-07 12:57 ` Javier González
2019-06-09 19:51 ` Matias Bjørling
2019-06-06 10:29 ` [PATCH 3/6] block: remove the bi_phys_segments field in struct bio Christoph Hellwig
2019-06-07 6:02 ` Hannes Reinecke
2019-06-07 16:45 ` Christoph Hellwig
2019-06-09 22:17 ` Nikolay Borisov
2019-06-10 18:30 ` Bart Van Assche
2019-06-06 10:29 ` [PATCH 4/6] block: simplify blk_recalc_rq_segments Christoph Hellwig
2019-06-07 6:03 ` Hannes Reinecke
2019-06-06 10:29 ` [PATCH 5/6] block: untangle the end of blk_bio_segment_split Christoph Hellwig
2019-06-07 6:04 ` Hannes Reinecke
2019-06-06 10:29 ` [PATCH 6/6] block: mark blk_rq_bio_prep as inline Christoph Hellwig
2019-06-07 6:04 ` Hannes Reinecke
2019-06-20 9:44 ` remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-20 16:33 ` Jens Axboe
2019-07-01 16:46 ` Jens Axboe
2019-07-02 13:34 ` Christoph Hellwig
[not found] ` <bfe8a4b5-901e-5ac4-e11c-0e6ccc4faec2@kernel.dk>
2019-07-02 18:29 ` Christoph Hellwig
2019-07-02 18:37 ` Jens Axboe
2019-07-03 0:00 ` Christoph Hellwig
2019-07-03 1:10 ` Jens Axboe
2019-07-03 1:32 ` Jens Axboe
2019-07-03 1:35 ` Christoph Hellwig
2019-07-03 12:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703121608.GC7671@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.