From: Boris Brezillon <boris.brezillon@collabora.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Steven Price <steven.price@arm.com>
Subject: Re: [RFC PATCH] mesa: Export BOs in RW mode
Date: Wed, 3 Jul 2019 15:56:16 +0200 [thread overview]
Message-ID: <20190703155616.1ed02d49@collabora.com> (raw)
In-Reply-To: <CAL_JsqLb3qjzp8+9mj3SA=E_avsF7VnC=vji9YvePHvoiqgNgg@mail.gmail.com>
On Wed, 3 Jul 2019 07:45:32 -0600
Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon
> <boris.brezillon@collabora.com> wrote:
> >
> > Exported BOs might be imported back, then mmap()-ed to be written
> > too. Most drivers handle that by mmap()-ing the GEM handle after it's
> > been imported, but, according to [1], this is illegal.
>
> It's not illegal, but is supposed to go thru the dmabuf mmap
> functions.
That's basically what I'm proposing here, just didn't post the patch
skipping the GET_OFFSET step and doing the mmap() on the dmabuf FD
instead of the DRM-node one, but I have it working for panfrost.
> However, none of the driver I've looked at (etnaviv, msm,
> v3d, vgem) do that. It probably works because it's the same driver
> doing the import and export or both drivers have essentially the same
> implementations.
Yes, but maybe that's something we should start fixing if mmap()-ing
the dmabuf is the recommended solution.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-03 13:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 13:33 [RFC PATCH] mesa: Export BOs in RW mode Boris Brezillon
2019-07-03 13:45 ` Rob Herring
2019-07-03 13:56 ` Boris Brezillon [this message]
2019-07-03 14:13 ` Steven Price
2019-07-03 14:33 ` Boris Brezillon
2019-07-03 14:50 ` Steven Price
2019-07-03 15:07 ` Boris Brezillon
2019-07-03 16:18 ` Daniel Vetter
2019-07-04 9:26 ` Steven Price
2019-07-04 9:46 ` [Mesa-dev] " Daniel Vetter
2019-07-04 16:37 ` [PATCH] dma-buf: Update docs to discourage use of dma_buf_mmap() Steven Price
2019-07-03 15:59 ` [RFC PATCH] mesa: Export BOs in RW mode Rob Herring
2019-07-03 16:15 ` Steven Price
2019-07-03 15:47 ` Daniel Vetter
2019-07-03 15:49 ` Daniel Vetter
2019-07-03 16:07 ` Alyssa Rosenzweig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703155616.1ed02d49@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mesa-dev@lists.freedesktop.org \
--cc=robh+dt@kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.