From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] Staging: mt7621-dma: mtk-hsdma: fix a coding style issue Date: Wed, 3 Jul 2019 18:32:32 +0200 Message-ID: <20190703163232.GA29325@kroah.com> References: <20190702080632.27470-1-fatihaltinpinar@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190702080632.27470-1-fatihaltinpinar@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: fatihaltinpinar@gmail.com Cc: matthias.bgg@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Tue, Jul 02, 2019 at 11:06:32AM +0300, fatihaltinpinar@gmail.com wrote: > From: Fatih ALTINPINAR > > Fixed a coding style issue. Removed curly brackets of an one > line if statement. > > Signed-off-by: Fatih ALTINPINAR > --- > drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c > index 0fbb9932d6bb..a58725dd2611 100644 > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c > @@ -664,9 +664,8 @@ static int mtk_hsdma_probe(struct platform_device *pdev) > return -EINVAL; > > hsdma = devm_kzalloc(&pdev->dev, sizeof(*hsdma), GFP_KERNEL); > - if (!hsdma) { > + if (!hsdma) > return -EINVAL; > - } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > base = devm_ioremap_resource(&pdev->dev, res); This change is already in my tree, always be sure to work against the proper kernel tree for doing new development. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F36C0650E for ; Wed, 3 Jul 2019 16:32:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48970218A0 for ; Wed, 3 Jul 2019 16:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ANK5hKSF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HlXDW6vx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48970218A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WerapnVAO2urpF9J6QFI+VDNcF5XojxhkLPxzsXHgxY=; b=ANK5hKSF0rxmgD X7Kn3+tNwtljtovoh4+wHp2bth6fP4Kri4AZ6Mbred2wFGJG6f033Fq8cT5oxDgVMFAPcWOKCsaOk QHKepaqyaK9qFu2zmKcDGP2YKatbSbbFGgrZW6+Q7TVlJDZjk5NyMYquknYfpecFdCiw1QyOuv55d P51hgjEiEbk76tiGPa/7oWdm1cRXFuTrWoc84LVhucIZKNlu2cC1OJzPoexmV8cNR925krT7dqHTn S2kvdPOQV8SiXEQFz5zHEe7W5hHriDpZmZmdvsUqTf0gQQn6cgTjBURYq3mNT+YRwn6/tCCb641AS Zmy2ZWDcSGRzEOdvR9AQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiiBT-000120-IQ; Wed, 03 Jul 2019 16:32:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiiBP-00011O-V0; Wed, 03 Jul 2019 16:32:37 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FB002187F; Wed, 3 Jul 2019 16:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562171554; bh=8hkx9D6cVHuLlyuoRR6plS3cZoqyazckirKKEEaVDhc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HlXDW6vx8wTFxhwAjRJH4wSDIXbJZ3SjmBvcvttiyLCS63EFVOW8+dJPOytcTUxD4 dIv7CTcdJKQrr2CVJHK32yAfvGXwaHezOLLG7CvxC4ztyPsXl7CsCKC3nJ3+MiTBtk vwyZ4dKaKJ/Y08WQBFNAg/BcSzS9zX0nRZy79KOk= Date: Wed, 3 Jul 2019 18:32:32 +0200 From: Greg KH To: fatihaltinpinar@gmail.com Subject: Re: [PATCH] Staging: mt7621-dma: mtk-hsdma: fix a coding style issue Message-ID: <20190703163232.GA29325@kroah.com> References: <20190702080632.27470-1-fatihaltinpinar@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190702080632.27470-1-fatihaltinpinar@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190703_093236_018288_E2CB893E X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: matthias.bgg@gmail.com, devel@driverdev.osuosl.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 02, 2019 at 11:06:32AM +0300, fatihaltinpinar@gmail.com wrote: > From: Fatih ALTINPINAR > > Fixed a coding style issue. Removed curly brackets of an one > line if statement. > > Signed-off-by: Fatih ALTINPINAR > --- > drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c > index 0fbb9932d6bb..a58725dd2611 100644 > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c > @@ -664,9 +664,8 @@ static int mtk_hsdma_probe(struct platform_device *pdev) > return -EINVAL; > > hsdma = devm_kzalloc(&pdev->dev, sizeof(*hsdma), GFP_KERNEL); > - if (!hsdma) { > + if (!hsdma) > return -EINVAL; > - } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > base = devm_ioremap_resource(&pdev->dev, res); This change is already in my tree, always be sure to work against the proper kernel tree for doing new development. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel