All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Aditya Swarup <aditya.swarup@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/i915: Use port clock to set correct N value
Date: Wed, 3 Jul 2019 21:53:10 +0300	[thread overview]
Message-ID: <20190703185310.GB5942@intel.com> (raw)
In-Reply-To: <20190627220708.31700-1-aditya.swarup@intel.com>

On Thu, Jun 27, 2019 at 03:07:07PM -0700, Aditya Swarup wrote:
> Use port_clock to check the clock values in n/cts lookup table instead
> of crtc_clock. As port_clock is already adjusted based on color mode set
> (8 bit or deep color), this will help in checking clock values for deep
> color modes from n/cts lookup table.
> 
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Pushed the series to dinq. Thanks.

> ---
>  drivers/gpu/drm/i915/display/intel_audio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
> index 840daff12246..156d524c29d9 100644
> --- a/drivers/gpu/drm/i915/display/intel_audio.c
> +++ b/drivers/gpu/drm/i915/display/intel_audio.c
> @@ -212,13 +212,11 @@ static u32 audio_config_hdmi_pixel_clock(const struct intel_crtc_state *crtc_sta
>  static int audio_config_hdmi_get_n(const struct intel_crtc_state *crtc_state,
>  				   int rate)
>  {
> -	const struct drm_display_mode *adjusted_mode =
> -		&crtc_state->base.adjusted_mode;
>  	int i;
>  
>  	for (i = 0; i < ARRAY_SIZE(hdmi_aud_ncts); i++) {
>  		if (rate == hdmi_aud_ncts[i].sample_rate &&
> -		    adjusted_mode->crtc_clock == hdmi_aud_ncts[i].clock) {
> +		    crtc_state->port_clock == hdmi_aud_ncts[i].clock) {
>  			return hdmi_aud_ncts[i].n;
>  		}
>  	}
> -- 
> 2.17.1

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2019-07-03 18:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 22:07 [PATCH v2 1/2] drm/i915: Use port clock to set correct N value Aditya Swarup
2019-06-27 22:07 ` [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color Aditya Swarup
2019-06-27 22:33 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: Use port clock to set correct N value Patchwork
2019-06-28 10:18 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-28 19:02 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-03 18:53 ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190703185310.GB5942@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=aditya.swarup@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.