From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: felix.j.degrood@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Deal with machines that expose less than three QGV points
Date: Wed, 3 Jul 2019 21:53:19 +0300 [thread overview]
Message-ID: <20190703185319.GC5942@intel.com> (raw)
In-Reply-To: <20190703180118.GZ24125@mdroper-desk.amr.corp.intel.com>
On Wed, Jul 03, 2019 at 11:01:18AM -0700, Matt Roper wrote:
> On Thu, Jun 06, 2019 at 03:42:10PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > When SAGV is forced to disabled/min/med/max in the BIOS pcode will
> > only hand us a single QGV point instead of the normal three. Fix
> > the code to deal with that instead declaring the bandwidth limit
> > to be 0 MB/s (and thus preventing any planes from being enabled).
> >
> > Also shrink the max_bw sturct a bit while at it, and change the
> > deratedbw type to unsigned since the code returns the bw as
> > an unsigned int.
> >
> > Since we now keep track of how many qgv points we got from pcode
> > we can drop the earlier check added for the "pcode doesn't
> > support the memory subsystem query" case.
> >
> > Cc: felix.j.degrood@intel.com
> > Cc: Mark Janes <mark.a.janes@intel.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
> > Fixes: c457d9cf256e ("drm/i915: Make sure we have enough memory bandwidth on ICL")
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110838
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This one slipped through the cracks, but it looks correct.
Yeah, also disappeared from my own radar due to patchwork getting
confused and moving the patch under Felix's authorship.
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Thanks.
>
> You'll need to re-spin the patch since intel_bw.c is under the display/
> folder now and enough time has passed that we probably want another CI
> run anyway.
git am is smart enough to deal with file renames usually, and nothing
has changed really so I trust the earlier ci results. Pushed to dinq.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-07-03 18:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 12:42 [PATCH] drm/i915: Deal with machines that expose less than three QGV points Ville Syrjala
2019-06-06 13:06 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-06-06 14:10 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-06 19:49 ` [PATCH] " Degrood, Felix J
2019-06-11 5:21 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-07-03 18:01 ` [PATCH] " Matt Roper
2019-07-03 18:53 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703185319.GC5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=felix.j.degrood@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.