From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH v2 1/7] dt-bindings: net: Add bindings for Realtek PHYs Date: Wed, 3 Jul 2019 15:08:43 -0700 Message-ID: <20190703220843.GJ250418@google.com> References: <20190703193724.246854-1-mka@chromium.org> <20190703213327.GH18473@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190703213327.GH18473@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Lunn Cc: Rob Herring , "David S . Miller" , Mark Rutland , Florian Fainelli , Heiner Kallweit , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Douglas Anderson List-Id: devicetree@vger.kernel.org On Wed, Jul 03, 2019 at 11:33:27PM +0200, Andrew Lunn wrote: > > I think if we're going to have custom properties for phys, we should > > have a compatible string to at least validate whether the custom > > properties are even valid for the node. > > Hi Rob > > What happens with other enumerable busses where a compatible string is > not used? > > The Ethernet PHY subsystem will ignore the compatible string and load > the driver which fits the enumeration data. Using the compatible > string only to get the right YAML validator seems wrong. I would > prefer adding some other property with a clear name indicates its is > selecting the validator, and has nothing to do with loading the > correct driver. And it can then be used as well for USB and PCI > devices etc. I also have doubts whether a compatible string is the right answer here. It's not needed/used by the subsystem, but would it be a required property because it's needed for validation?