From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Muchun Song <smuchun@gmail.com>,
rafael@kernel.org, prsood@codeaurora.org, mojha@codeaurora.org,
gkohli@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 OPT1] driver core: Fix use-after-free and double free on glue directory
Date: Thu, 4 Jul 2019 07:41:26 +0200 [thread overview]
Message-ID: <20190704054126.GD347@kroah.com> (raw)
In-Reply-To: <01ca95431a642133293534502975765dba993ada.camel@kernel.crashing.org>
On Thu, Jul 04, 2019 at 08:57:53AM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2019-07-03 at 21:37 +0200, Greg KH wrote:
> > Ok, I guess I have to take this patch, as the other one is so bad :)
> >
> > But, I need a very large comment here saying why we are poking around in
> > a kref and why we need to do this, at the expense of anything else.
> >
> > So can you respin this patch with a comment here to help explain it so
> > we have a chance to understand it when we run across this line in 10
> > years?
>
> Also are we confident that an open dir on the glue dir from userspace
> won't keep the kref up ?
How do you "open" a directory which raises the kref?
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-04 5:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 14:38 [PATCH v1 OPT1] driver core: Fix use-after-free and double free on glue directory Muchun Song
2019-07-03 19:37 ` Greg KH
2019-07-03 22:57 ` Benjamin Herrenschmidt
2019-07-04 5:41 ` Greg KH [this message]
2019-07-04 6:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704054126.GD347@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=gkohli@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=prsood@codeaurora.org \
--cc=rafael@kernel.org \
--cc=smuchun@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.