From: Denis Efremov <efremov@linux.com>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Denis Efremov <efremov@linux.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Josh Triplett <josh@joshtriplett.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] torture: remove exporting of internal functions
Date: Thu, 4 Jul 2019 15:57:19 +0300 [thread overview]
Message-ID: <20190704125719.31290-1-efremov@linux.com> (raw)
The functions torture_onoff_cleanup, torture_shuffle_cleanup are declared
as static and marked as EXPORT_SYMBOL. It's a bit confusing for an
internal function to be exported. The area of visibility for such function
is its .c file and all other modules. Other *.c files of the same module
can't use it, despite all other modules can. Relying on the fact that these
are the internal functions and they are not a crucial part of the API, the
patch removes the EXPORT_SYMBOL marking of the torture_onoff_cleanup and
torture_shuffle_cleanup. The patch complements commit cc47ae083026
("rcutorture: Abstract torture-test cleanup").
Signed-off-by: Denis Efremov <efremov@linux.com>
---
kernel/torture.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/torture.c b/kernel/torture.c
index 17b2be9bde12..fbbcc4abe426 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -263,7 +263,6 @@ static void torture_onoff_cleanup(void)
onoff_task = NULL;
#endif /* #ifdef CONFIG_HOTPLUG_CPU */
}
-EXPORT_SYMBOL_GPL(torture_onoff_cleanup);
/*
* Print online/offline testing statistics.
@@ -449,7 +448,6 @@ static void torture_shuffle_cleanup(void)
}
shuffler_task = NULL;
}
-EXPORT_SYMBOL_GPL(torture_shuffle_cleanup);
/*
* Variables for auto-shutdown. This allows "lights out" torture runs
--
2.21.0
next reply other threads:[~2019-07-04 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 12:57 Denis Efremov [this message]
2019-07-04 14:19 ` [PATCH] torture: remove exporting of internal functions Paul E. McKenney
2019-07-04 14:46 ` Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704125719.31290-1-efremov@linux.com \
--to=efremov@linux.com \
--cc=dave@stgolabs.net \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.