From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F88EC0651F for ; Thu, 4 Jul 2019 20:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68A9F218A3 for ; Thu, 4 Jul 2019 20:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="vHe0b/q6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbfGDUmT (ORCPT ); Thu, 4 Jul 2019 16:42:19 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38494 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbfGDUmT (ORCPT ); Thu, 4 Jul 2019 16:42:19 -0400 Received: by mail-pl1-f194.google.com with SMTP id 9so3545695ple.5 for ; Thu, 04 Jul 2019 13:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=JtQVAQz6NVyH2NItSA5pmHp1/PwtbtiVXqtTWIa5Jvg=; b=vHe0b/q666zEE3c2nrbReFiDm6+Zdp14v0xC5Z1hgqUaPIpDuevVWGaM2wD80Ct6UO BHnbptgVI9NWagXJ4QkkZp8zMCfFbiai/kJQHlDFjiSFD3wtlAcCRHc4AJaUXmwCBjui bTeAijyVOMy7Y8QMGa5OV1x2zh5k46YvTVdFAgxzazgPo+Mn+Prp+1wwHdciPILzZQMZ QIjP9ZISG6GxTJr4w6yQ0iqfxxqhPn4kVMvMXPr3QDQmpj8bgYMPNMyeFg+PHnR23LbC L1pngCZWB4+2fkvdHKyNRQehS56M6Moe4UB7a7YmHjcRU1UypYjU7XnRValIP9GnaY9h YpSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=JtQVAQz6NVyH2NItSA5pmHp1/PwtbtiVXqtTWIa5Jvg=; b=snkaf6nKzxU5BexWFT3nrXkAEOrMYv2fx6JFaNwaCPL13p4pKrKDBtmw8BkHeDOonr a1JWY8DyPIC5IBPRiCnbtlMipBmEHFC6UEXemrDxDyR8uDmZ6T1u6OS6WbFxUoIe8J7y sAkK0Eldx6MDGtvK+ShfQotkk1VXMPi/HcM0RY6SFt1vEE/MN1KaqLp4wsNbYAoIHqNd 22qpa1GXQzXEVjL1KfHoVHsvIfhhS+YZ/lTqQZx4vQLCC38QVk31S746TM3zwVAWMr1h 5t46gAmVJ0s1Z6qblv8MoNopV78eEk8srakmSIOhkOvCPD7gWlpHzmx1TO9Pld7RXo39 fKwQ== X-Gm-Message-State: APjAAAUwP/VOaXrRTE9iS7xLQ1OLmTBqTuyqRaw9RgfY9ymTtsO68+46 E2f3QdCSNHXHW62gIZfY7+8FAw== X-Google-Smtp-Source: APXvYqzQ8AsnCq4ngmBo7O1aaeOK29eAo6/X+aRaJQgUmDdb1YMpWAJ987/eMo0Agxx6mFiFUrhkTQ== X-Received: by 2002:a17:902:e211:: with SMTP id ce17mr181011plb.193.1562272938912; Thu, 04 Jul 2019 13:42:18 -0700 (PDT) Received: from cakuba.netronome.com ([2601:646:8e00:e50::3]) by smtp.gmail.com with ESMTPSA id h26sm13468206pfq.64.2019.07.04.13.42.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 13:42:18 -0700 (PDT) Date: Thu, 4 Jul 2019 13:42:10 -0700 From: Jakub Kicinski To: Jiri Olsa Cc: Alexei Starovoitov , Daniel Borkmann , Michael Petlan , netdev@vger.kernel.org, bpf@vger.kernel.org, Martin KaFai Lau Subject: Re: [PATCH] tools bpftool: Fix json dump crash on powerpc Message-ID: <20190704134210.17b8407c@cakuba.netronome.com> In-Reply-To: <20190704085856.17502-1-jolsa@kernel.org> References: <20190704085856.17502-1-jolsa@kernel.org> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, 4 Jul 2019 10:58:56 +0200, Jiri Olsa wrote: > Michael reported crash with by bpf program in json mode on powerpc: > > # bpftool prog -p dump jited id 14 > [{ > "name": "0xd00000000a9aa760", > "insns": [{ > "pc": "0x0", > "operation": "nop", > "operands": [null > ] > },{ > "pc": "0x4", > "operation": "nop", > "operands": [null > ] > },{ > "pc": "0x8", > "operation": "mflr", > Segmentation fault (core dumped) > > The code is assuming char pointers in format, which is not always > true at least for powerpc. Fixing this by dumping the whole string > into buffer based on its format. > > Please note that libopcodes code does not check return values from > fprintf callback, so there's no point to return error in case of > allocation failure. Well, it doesn't check it today, it may perhaps do it in the future? Let's flip the question - since it doesn't check it today, why not propagate the error? :) We should stay close to how fprintf would behave, IMHO. Fixes: 107f041212c1 ("tools: bpftool: add JSON output for `bpftool prog dump jited *` command") > Reported-by: Michael Petlan > Signed-off-by: Jiri Olsa