From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Date: Fri, 05 Jul 2019 12:41:51 +0000 Subject: Re: [PATCH -next] drm/i915: Remove set but not used variable 'encoder' Message-Id: <20190705124151.GN5942@intel.com> List-Id: References: <20190705113112.64715-1-yuehaibing@huawei.com> In-Reply-To: <20190705113112.64715-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: YueHaibing Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, manasi.d.navare@intel.com, dhinakaran.pandiyan@intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org On Fri, Jul 05, 2019 at 11:31:12AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: >=20 > drivers/gpu/drm/i915/display/intel_dp.c: In function 'intel_dp_set_drrs_s= tate': > drivers/gpu/drm/i915/display/intel_dp.c:6623:24: warning: > variable 'encoder' set but not used [-Wunused-but-set-variable] >=20 > It's never used, so can be removed.Also remove related > variable 'dig_port' >=20 > Signed-off-by: YueHaibing Applied to drm-intel-next-queued. Thanks for the patch. > --- > drivers/gpu/drm/i915/display/intel_dp.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i9= 15/display/intel_dp.c > index 8f7188d71d08..0bdb7ecc5a81 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6620,8 +6620,6 @@ static void intel_dp_set_drrs_state(struct drm_i915= _private *dev_priv, > const struct intel_crtc_state *crtc_state, > int refresh_rate) > { > - struct intel_encoder *encoder; > - struct intel_digital_port *dig_port =3D NULL; > struct intel_dp *intel_dp =3D dev_priv->drrs.dp; > struct intel_crtc *intel_crtc =3D to_intel_crtc(crtc_state->base.crtc); > enum drrs_refresh_rate_type index =3D DRRS_HIGH_RR; > @@ -6636,9 +6634,6 @@ static void intel_dp_set_drrs_state(struct drm_i915= _private *dev_priv, > return; > } > =20 > - dig_port =3D dp_to_dig_port(intel_dp); > - encoder =3D &dig_port->base; > - > if (!intel_crtc) { > DRM_DEBUG_KMS("DRRS: intel_crtc not initialized\n"); > return; >=20 >=20 --=20 Ville Syrj=E4l=E4 Intel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH -next] drm/i915: Remove set but not used variable 'encoder' Date: Fri, 5 Jul 2019 15:41:51 +0300 Message-ID: <20190705124151.GN5942@intel.com> References: <20190705113112.64715-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190705113112.64715-1-yuehaibing@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YueHaibing Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, manasi.d.navare@intel.com, dhinakaran.pandiyan@intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdWwgMDUsIDIwMTkgYXQgMTE6MzE6MTJBTSArMDAwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBGaXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUnIHdhcm5pbmc6Cj4gCj4g ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcC5jOiBJbiBmdW5jdGlvbiAnaW50 ZWxfZHBfc2V0X2RycnNfc3RhdGUnOgo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZHAuYzo2NjIzOjI0OiB3YXJuaW5nOgo+ICB2YXJpYWJsZSAnZW5jb2Rlcicgc2V0IGJ1dCBu b3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiAKPiBJdCdzIG5ldmVyIHVzZWQs IHNvIGNhbiBiZSByZW1vdmVkLkFsc28gcmVtb3ZlIHJlbGF0ZWQKPiB2YXJpYWJsZSAnZGlnX3Bv cnQnCj4gCj4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8eXVlaGFpYmluZ0BodWF3ZWkuY29t PgoKQXBwbGllZCB0byBkcm0taW50ZWwtbmV4dC1xdWV1ZWQuIFRoYW5rcyBmb3IgdGhlIHBhdGNo LgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcC5jIHwgNSAt LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9kcC5jCj4gaW5kZXggOGY3MTg4ZDcxZDA4Li4wYmRiN2VjYzVh ODEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcC5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcC5jCj4gQEAgLTY2 MjAsOCArNjYyMCw2IEBAIHN0YXRpYyB2b2lkIGludGVsX2RwX3NldF9kcnJzX3N0YXRlKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCSAgICBjb25zdCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkJCSAgICBpbnQgcmVmcmVzaF9yYXRlKQo+ ICB7Cj4gLQlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcjsKPiAtCXN0cnVjdCBpbnRlbF9k aWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gTlVMTDsKPiAgCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHAgPSBkZXZfcHJpdi0+ZHJycy5kcDsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRj ID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ICAJZW51bSBkcnJzX3Jl ZnJlc2hfcmF0ZV90eXBlIGluZGV4ID0gRFJSU19ISUdIX1JSOwo+IEBAIC02NjM2LDkgKzY2MzQs NiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kcF9zZXRfZHJyc19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAKPiAtCWRpZ19wb3J0ID0g ZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+IC0JZW5jb2RlciA9ICZkaWdfcG9ydC0+YmFzZTsK PiAtCj4gIAlpZiAoIWludGVsX2NydGMpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJEUlJTOiBpbnRl bF9jcnRjIG5vdCBpbml0aWFsaXplZFxuIik7Cj4gIAkJcmV0dXJuOwo+IAo+IAoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A210AC4649B for ; Fri, 5 Jul 2019 12:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B05E218A3 for ; Fri, 5 Jul 2019 12:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728941AbfGEMmX (ORCPT ); Fri, 5 Jul 2019 08:42:23 -0400 Received: from mga07.intel.com ([134.134.136.100]:4897 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726921AbfGEMmW (ORCPT ); Fri, 5 Jul 2019 08:42:22 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2019 05:41:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,455,1557212400"; d="scan'208";a="248182207" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga001.jf.intel.com with SMTP; 05 Jul 2019 05:41:52 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 05 Jul 2019 15:41:51 +0300 Date: Fri, 5 Jul 2019 15:41:51 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: YueHaibing Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, imre.deak@intel.com, dhinakaran.pandiyan@intel.com, chris@chris-wilson.co.uk, manasi.d.navare@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] drm/i915: Remove set but not used variable 'encoder' Message-ID: <20190705124151.GN5942@intel.com> References: <20190705113112.64715-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190705113112.64715-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 05, 2019 at 11:31:12AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/i915/display/intel_dp.c: In function 'intel_dp_set_drrs_state': > drivers/gpu/drm/i915/display/intel_dp.c:6623:24: warning: > variable 'encoder' set but not used [-Wunused-but-set-variable] > > It's never used, so can be removed.Also remove related > variable 'dig_port' > > Signed-off-by: YueHaibing Applied to drm-intel-next-queued. Thanks for the patch. > --- > drivers/gpu/drm/i915/display/intel_dp.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 8f7188d71d08..0bdb7ecc5a81 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6620,8 +6620,6 @@ static void intel_dp_set_drrs_state(struct drm_i915_private *dev_priv, > const struct intel_crtc_state *crtc_state, > int refresh_rate) > { > - struct intel_encoder *encoder; > - struct intel_digital_port *dig_port = NULL; > struct intel_dp *intel_dp = dev_priv->drrs.dp; > struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state->base.crtc); > enum drrs_refresh_rate_type index = DRRS_HIGH_RR; > @@ -6636,9 +6634,6 @@ static void intel_dp_set_drrs_state(struct drm_i915_private *dev_priv, > return; > } > > - dig_port = dp_to_dig_port(intel_dp); > - encoder = &dig_port->base; > - > if (!intel_crtc) { > DRM_DEBUG_KMS("DRRS: intel_crtc not initialized\n"); > return; > > -- Ville Syrjälä Intel