From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Date: Fri, 05 Jul 2019 12:42:04 +0000 Subject: Re: [PATCH -next] drm/i915: Remove set but not used variable 'intel_dig_port' Message-Id: <20190705124204.GO5942@intel.com> List-Id: References: <20190705113138.65880-1-yuehaibing@huawei.com> In-Reply-To: <20190705113138.65880-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: YueHaibing Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, kernel-janitors@vger.kernel.org, lucas.demarchi@intel.com, linux-kernel@vger.kernel.org, jose.souza@intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org On Fri, Jul 05, 2019 at 11:31:38AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: >=20 > drivers/gpu/drm/i915/display/intel_ddi.c: In function 'intel_ddi_get_conf= ig': > drivers/gpu/drm/i915/display/intel_ddi.c:3774:29: warning: > variable 'intel_dig_port' set but not used [-Wunused-but-set-variable] > struct intel_digital_port *intel_dig_port; >=20 > It is never used, so can be removed. >=20 > Signed-off-by: YueHaibing Applied to drm-intel-next-queued. Thanks for the patch. > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i= 915/display/intel_ddi.c > index a4172595c8d8..30e48609db1d 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3771,7 +3771,6 @@ void intel_ddi_get_config(struct intel_encoder *enc= oder, > struct drm_i915_private *dev_priv =3D to_i915(encoder->base.dev); > struct intel_crtc *intel_crtc =3D to_intel_crtc(pipe_config->base.crtc); > enum transcoder cpu_transcoder =3D pipe_config->cpu_transcoder; > - struct intel_digital_port *intel_dig_port; > u32 temp, flags =3D 0; > =20 > /* XXX: DSI transcoder paranoia */ > @@ -3810,7 +3809,6 @@ void intel_ddi_get_config(struct intel_encoder *enc= oder, > switch (temp & TRANS_DDI_MODE_SELECT_MASK) { > case TRANS_DDI_MODE_SELECT_HDMI: > pipe_config->has_hdmi_sink =3D true; > - intel_dig_port =3D enc_to_dig_port(&encoder->base); > =20 > pipe_config->infoframes.enable |> intel_hdmi_infoframes_enabled(en= coder, pipe_config); >=20 >=20 --=20 Ville Syrj=E4l=E4 Intel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH -next] drm/i915: Remove set but not used variable 'intel_dig_port' Date: Fri, 5 Jul 2019 15:42:04 +0300 Message-ID: <20190705124204.GO5942@intel.com> References: <20190705113138.65880-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190705113138.65880-1-yuehaibing@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YueHaibing Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, kernel-janitors@vger.kernel.org, lucas.demarchi@intel.com, linux-kernel@vger.kernel.org, jose.souza@intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdWwgMDUsIDIwMTkgYXQgMTE6MzE6MzhBTSArMDAwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBGaXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUnIHdhcm5pbmc6Cj4gCj4g ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kZGkuYzogSW4gZnVuY3Rpb24gJ2lu dGVsX2RkaV9nZXRfY29uZmlnJzoKPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVs X2RkaS5jOjM3NzQ6Mjk6IHdhcm5pbmc6Cj4gIHZhcmlhYmxlICdpbnRlbF9kaWdfcG9ydCcgc2V0 IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiAgIHN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0Owo+IAo+IEl0IGlzIG5ldmVyIHVzZWQsIHNv IGNhbiBiZSByZW1vdmVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFl1ZUhhaWJpbmcgPHl1ZWhhaWJp bmdAaHVhd2VpLmNvbT4KCkFwcGxpZWQgdG8gZHJtLWludGVsLW5leHQtcXVldWVkLiBUaGFua3Mg Zm9yIHRoZSBwYXRjaC4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZGRpLmMgfCAyIC0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RkaS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kZGkuYwo+IGluZGV4IGE0MTcyNTk1Yzhk OC4uMzBlNDg2MDlkYjFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3Bs YXkvaW50ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVs X2RkaS5jCj4gQEAgLTM3NzEsNyArMzc3MSw2IEBAIHZvaWQgaW50ZWxfZGRpX2dldF9jb25maWco c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiAgCXN0cnVjdCBpbnRl bF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhwaXBlX2NvbmZpZy0+YmFzZS5jcnRj KTsKPiAgCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IHBpcGVfY29uZmlnLT5jcHVf dHJhbnNjb2RlcjsKPiAtCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0 Owo+ICAJdTMyIHRlbXAsIGZsYWdzID0gMDsKPiAgCj4gIAkvKiBYWFg6IERTSSB0cmFuc2NvZGVy IHBhcmFub2lhICovCj4gQEAgLTM4MTAsNyArMzgwOSw2IEBAIHZvaWQgaW50ZWxfZGRpX2dldF9j b25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlzd2l0Y2ggKHRlbXAgJiBU UkFOU19ERElfTU9ERV9TRUxFQ1RfTUFTSykgewo+ICAJY2FzZSBUUkFOU19ERElfTU9ERV9TRUxF Q1RfSERNSToKPiAgCQlwaXBlX2NvbmZpZy0+aGFzX2hkbWlfc2luayA9IHRydWU7Cj4gLQkJaW50 ZWxfZGlnX3BvcnQgPSBlbmNfdG9fZGlnX3BvcnQoJmVuY29kZXItPmJhc2UpOwo+ICAKPiAgCQlw aXBlX2NvbmZpZy0+aW5mb2ZyYW1lcy5lbmFibGUgfD0KPiAgCQkJaW50ZWxfaGRtaV9pbmZvZnJh bWVzX2VuYWJsZWQoZW5jb2RlciwgcGlwZV9jb25maWcpOwo+IAo+IAoKLS0gClZpbGxlIFN5cmrD pGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E2D3C46499 for ; Fri, 5 Jul 2019 12:42:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73297218A3 for ; Fri, 5 Jul 2019 12:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbfGEMmL (ORCPT ); Fri, 5 Jul 2019 08:42:11 -0400 Received: from mga14.intel.com ([192.55.52.115]:5662 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727295AbfGEMmL (ORCPT ); Fri, 5 Jul 2019 08:42:11 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2019 05:42:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,455,1557212400"; d="scan'208";a="169667533" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 05 Jul 2019 05:42:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 05 Jul 2019 15:42:04 +0300 Date: Fri, 5 Jul 2019 15:42:04 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: YueHaibing Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, lucas.demarchi@intel.com, imre.deak@intel.com, jose.souza@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] drm/i915: Remove set but not used variable 'intel_dig_port' Message-ID: <20190705124204.GO5942@intel.com> References: <20190705113138.65880-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190705113138.65880-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 05, 2019 at 11:31:38AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/i915/display/intel_ddi.c: In function 'intel_ddi_get_config': > drivers/gpu/drm/i915/display/intel_ddi.c:3774:29: warning: > variable 'intel_dig_port' set but not used [-Wunused-but-set-variable] > struct intel_digital_port *intel_dig_port; > > It is never used, so can be removed. > > Signed-off-by: YueHaibing Applied to drm-intel-next-queued. Thanks for the patch. > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index a4172595c8d8..30e48609db1d 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3771,7 +3771,6 @@ void intel_ddi_get_config(struct intel_encoder *encoder, > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->base.crtc); > enum transcoder cpu_transcoder = pipe_config->cpu_transcoder; > - struct intel_digital_port *intel_dig_port; > u32 temp, flags = 0; > > /* XXX: DSI transcoder paranoia */ > @@ -3810,7 +3809,6 @@ void intel_ddi_get_config(struct intel_encoder *encoder, > switch (temp & TRANS_DDI_MODE_SELECT_MASK) { > case TRANS_DDI_MODE_SELECT_HDMI: > pipe_config->has_hdmi_sink = true; > - intel_dig_port = enc_to_dig_port(&encoder->base); > > pipe_config->infoframes.enable |= > intel_hdmi_infoframes_enabled(encoder, pipe_config); > > -- Ville Syrjälä Intel