From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EB5C4649E for ; Fri, 5 Jul 2019 15:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D60F216E3 for ; Fri, 5 Jul 2019 15:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbfGEPyd convert rfc822-to-8bit (ORCPT ); Fri, 5 Jul 2019 11:54:33 -0400 Received: from mailout02.agenturserver.de ([185.15.192.33]:47437 "EHLO mailout02.agenturserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726696AbfGEPyc (ORCPT ); Fri, 5 Jul 2019 11:54:32 -0400 X-Greylist: delayed 419 seconds by postgrey-1.27 at vger.kernel.org; Fri, 05 Jul 2019 11:54:30 EDT Received: from mail02.agenturserver.de (mail02.internal [172.16.51.35]) by mailout02.agenturserver.de (Postfix) with ESMTP id 1AA7B1240ED; Fri, 5 Jul 2019 17:47:30 +0200 (CEST) Received: from localhost (ac02.internal [172.16.51.82]) by mail02.agenturserver.de (Postfix) with ESMTP id 08E9080758; Fri, 5 Jul 2019 17:47:30 +0200 (CEST) Received: from mail.agenturserver.de ([172.16.51.35]) by localhost (ac02.mittwald.de [172.16.51.82]) (amavisd-new, port 10026) with ESMTP id a934Vr1f9rZE; Fri, 5 Jul 2019 17:47:29 +0200 (CEST) Received: from karo-electronics.de (unknown [89.1.81.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lw@karo-electronics.de) by mail.agenturserver.de (Postfix) with ESMTPSA; Fri, 5 Jul 2019 17:47:28 +0200 (CEST) Date: Fri, 5 Jul 2019 17:47:27 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Sven Van Asbroeck Cc: Vinod Koul , Shawn Guo , Sascha Hauer , Linux Kernel Mailing List , NXP Linux Team , Pengutronix Kernel Team , dmaengine@vger.kernel.org, Dan Williams , Robin Gong , Fabio Estevam , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path Message-ID: <20190705174727.30c616aa@karo-electronics.de> In-Reply-To: References: <20190624140731.24080-1-TheSven73@gmail.com> <20190705072847.GA2911@vkoul-mobl> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi, On Fri, 5 Jul 2019 08:26:12 -0400 Sven Van Asbroeck wrote: > Hi Vinod, > > On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul wrote: > > > > > + if (ret) > > > + dev_warn(&pdev->dev, "failed to get firmware name\n"); > > > > if should have braces! > > Applied after fixing braces! > > checkpatch.pl output after adding braces: > > WARNING: braces {} are not necessary for single statement blocks > #102: FILE: drivers/dma/imx-sdma.c:2165: > + if (ret) { > + dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); > + } > You changed the braces in the wrong place! The comment applied to the previous 'if (ret)' which has an else clause with braces, so the if clause needs braces too. Lothar Waßmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E1F8C4649E for ; Fri, 5 Jul 2019 15:51:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2327D2184C for ; Fri, 5 Jul 2019 15:51:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AsMgQatu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2327D2184C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uAC7rFUcQiHAWnu7rDfuukdNZmiZtoc9v0U1ac/6Hns=; b=AsMgQatu1qlUf8 QCHxTskaL5zYWkmVzsG2WCSS65hMjE3qfMWf7Aled4N7xpZUMLZD1Yav7idHQ7WGPiPTermz6e+f/ masPKr4xCdFBlThidKW6whg0bCmIpxw4IWlYO11GTzqtaL4wqQb0DLoO9349C3kmRpCn3DRwiuf0v fjxBh9HeF3vuPkzKxqNzTh0MiF5E5XGkVIuz400MWCmhU6jd8OlxQbHe+JX3nxecWfdwYbBvGNQUK Lutw7UZk/oAlYTEioA16kpidA+Sy7nEsJi42TAD36tAJQ283sOX6+tV1JCmTINTWG+YLZNIX3jnlw NH0GROphVcdsKn6w47MA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hjQUm-00074S-G8; Fri, 05 Jul 2019 15:51:32 +0000 Received: from mailout02.agenturserver.de ([185.15.192.33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjQQw-0001wu-5I for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2019 15:47:37 +0000 Received: from mail02.agenturserver.de (mail02.internal [172.16.51.35]) by mailout02.agenturserver.de (Postfix) with ESMTP id 1AA7B1240ED; Fri, 5 Jul 2019 17:47:30 +0200 (CEST) Received: from localhost (ac02.internal [172.16.51.82]) by mail02.agenturserver.de (Postfix) with ESMTP id 08E9080758; Fri, 5 Jul 2019 17:47:30 +0200 (CEST) Received: from mail.agenturserver.de ([172.16.51.35]) by localhost (ac02.mittwald.de [172.16.51.82]) (amavisd-new, port 10026) with ESMTP id a934Vr1f9rZE; Fri, 5 Jul 2019 17:47:29 +0200 (CEST) Received: from karo-electronics.de (unknown [89.1.81.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lw@karo-electronics.de) by mail.agenturserver.de (Postfix) with ESMTPSA; Fri, 5 Jul 2019 17:47:28 +0200 (CEST) Date: Fri, 5 Jul 2019 17:47:27 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Sven Van Asbroeck Subject: Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path Message-ID: <20190705174727.30c616aa@karo-electronics.de> In-Reply-To: References: <20190624140731.24080-1-TheSven73@gmail.com> <20190705072847.GA2911@vkoul-mobl> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190705_084734_373364_FF498239 X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Sascha Hauer , Linux Kernel Mailing List , Vinod Koul , NXP Linux Team , Pengutronix Kernel Team , dmaengine@vger.kernel.org, Dan Williams , Robin Gong , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBGcmksIDUgSnVsIDIwMTkgMDg6MjY6MTIgLTA0MDAgU3ZlbiBWYW4gQXNicm9lY2sg d3JvdGU6Cj4gSGkgVmlub2QsCj4gCj4gT24gRnJpLCBKdWwgNSwgMjAxOSBhdCAzOjMyIEFNIFZp bm9kIEtvdWwgPHZrb3VsQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gIAo+ID4gPiArICAgICAgICAg ICAgIGlmIChyZXQpCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBkZXZfd2FybigmcGRldi0+ ZGV2LCAiZmFpbGVkIHRvIGdldCBmaXJtd2FyZSBuYW1lXG4iKTsgIAo+ID4KPiA+IGlmIHNob3Vs ZCBoYXZlIGJyYWNlcyEKPiA+IEFwcGxpZWQgYWZ0ZXIgZml4aW5nIGJyYWNlcyEgIAo+IAo+IGNo ZWNrcGF0Y2gucGwgb3V0cHV0IGFmdGVyIGFkZGluZyBicmFjZXM6Cj4gCj4gV0FSTklORzogYnJh Y2VzIHt9IGFyZSBub3QgbmVjZXNzYXJ5IGZvciBzaW5nbGUgc3RhdGVtZW50IGJsb2Nrcwo+ICMx MDI6IEZJTEU6IGRyaXZlcnMvZG1hL2lteC1zZG1hLmM6MjE2NToKPiArIGlmIChyZXQpIHsKPiAr IGRldl93YXJuKCZwZGV2LT5kZXYsICJmYWlsZWQgdG8gZ2V0IGZpcm13YXJlIGZyb20gZGV2aWNl IHRyZWVcbiIpOwo+ICsgfQo+IApZb3UgY2hhbmdlZCB0aGUgYnJhY2VzIGluIHRoZSB3cm9uZyBw bGFjZSEKVGhlIGNvbW1lbnQgYXBwbGllZCB0byB0aGUgcHJldmlvdXMgJ2lmIChyZXQpJyB3aGlj aCBoYXMgYW4gZWxzZSBjbGF1c2UKd2l0aCBicmFjZXMsIHNvIHRoZSBpZiBjbGF1c2UgbmVlZHMg YnJhY2VzIHRvby4KCgpMb3RoYXIgV2HDn21hbm4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK