From: Pavel Machek <pavel@ucw.cz>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: jacek.anaszewski@gmail.com, dmurphy@ti.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
tomi.valkeinen@ti.com
Subject: Re: [PATCH 2/2] leds: tlc591xx: Use the OF version of the LED registration function
Date: Fri, 5 Jul 2019 22:24:33 +0200 [thread overview]
Message-ID: <20190705202433.GB5445@amd> (raw)
In-Reply-To: <20190701152602.31716-3-jjhiblot@ti.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On Mon 2019-07-01 17:26:02, Jean-Jacques Hiblot wrote:
> The driver parses the device-tree to identify which LED should be handled.
> Since the information about the device node is known at this time, we can
> provide the LED core with it. It may be useful later.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> @@ -207,7 +207,7 @@ tlc591xx_probe(struct i2c_client *client,
> led->led_no = idx++;
> led->ldev.brightness_set_blocking = tlc591xx_brightness_set;
> led->ldev.max_brightness = LED_FULL;
> - err = devm_led_classdev_register(dev, &led->ldev);
> + err = devm_of_led_classdev_register(dev, child, &led->ldev);
> if (err < 0) {
> dev_err(dev, "couldn't register LED %s\n",
> led->ldev.name);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2019-07-05 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 15:26 [PATCH 0/2] leds: tlc591xx: switch to OF and managed API Jean-Jacques Hiblot
2019-07-01 15:26 ` Jean-Jacques Hiblot
2019-07-01 15:26 ` [PATCH 1/2] leds: tlc591xx: simplify driver by using the managed led API Jean-Jacques Hiblot
2019-07-01 15:26 ` Jean-Jacques Hiblot
2019-07-01 15:35 ` Dan Murphy
2019-07-01 15:35 ` Dan Murphy
2019-07-05 10:17 ` Pavel Machek
2019-07-01 15:26 ` [PATCH 2/2] leds: tlc591xx: Use the OF version of the LED registration function Jean-Jacques Hiblot
2019-07-01 15:26 ` Jean-Jacques Hiblot
2019-07-01 15:36 ` Dan Murphy
2019-07-01 15:36 ` Dan Murphy
2019-07-05 20:24 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705202433.GB5445@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.