From: Greg KH <greg@kroah.com>
To: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: stable@vger.kernel.org, linux-rdma@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: [PATCH] IB/hfi1: Close PSM sdma_progress sleep window
Date: Sat, 6 Jul 2019 07:08:57 +0200 [thread overview]
Message-ID: <20190706050857.GA5322@kroah.com> (raw)
In-Reply-To: <20190624201537.170286.13849.stgit@awfm-01.aw.intel.com>
On Mon, Jun 24, 2019 at 04:15:37PM -0400, Mike Marciniszyn wrote:
> commit da9de5f8527f4b9efc82f967d29a583318c034c7 upstream.
>
> The call to sdma_progress() is called outside the wait lock.
>
> In this case, there is a race condition where sdma_progress() can return
> false and the sdma_engine can idle. If that happens, there will be no
> more sdma interrupts to cause the wakeup and the user_sdma xmit will hang.
>
> Fix by moving the lock to enclose the sdma_progress() call.
>
> Also, delete busycount. The need for this was removed by:
> commit bcad29137a97 ("IB/hfi1: Serve the most starved iowait entry first")
>
> Ported to linux-4.9.y.
Now applied, thanks.
Note, this already is in 4.14.132 and 4.19.57 so I didn't need the
backports for those kernels.
greg k-h
next prev parent reply other threads:[~2019-07-06 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 20:15 [PATCH] IB/hfi1: Close PSM sdma_progress sleep window Mike Marciniszyn
2019-07-06 5:08 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-24 20:17 Mike Marciniszyn
2019-06-24 20:19 Mike Marciniszyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190706050857.GA5322@kroah.com \
--to=greg@kroah.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.