From: Al Viro <viro@zeniv.linux.org.uk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, Per.Hallsmark@windriver.com
Subject: Re: [PATCH 1/2] proc: revalidate directories created with proc_net_mkdir()
Date: Sun, 7 Jul 2019 02:03:20 +0100 [thread overview]
Message-ID: <20190707010317.GR17978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190706165201.GA10550@avx2>
On Sat, Jul 06, 2019 at 07:52:02PM +0300, Alexey Dobriyan wrote:
> +struct proc_dir_entry *_proc_mkdir(const char *name, umode_t mode,
> + struct proc_dir_entry **parent, void *data)
Two underscores, please...
> + parent->nlink++;
> + pde = proc_register(parent, pde);
> + if (!pde)
> + parent->nlink++;
Really?
next prev parent reply other threads:[~2019-07-07 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 16:52 [PATCH 1/2] proc: revalidate directories created with proc_net_mkdir() Alexey Dobriyan
2019-07-07 1:03 ` Al Viro [this message]
2019-07-07 8:03 ` Alexey Dobriyan
2019-07-07 19:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190707010317.GR17978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Per.Hallsmark@windriver.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.