From: Sam Ravnborg <sam@ravnborg.org>
To: Maya Rashish <coypu@sdf.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Remove unused function drm_agp_bind_pages
Date: Mon, 8 Jul 2019 10:18:16 +0200 [thread overview]
Message-ID: <20190708081816.GA27604@ravnborg.org> (raw)
In-Reply-To: <20190707174009.GA13667@SDF.ORG>
Hi Maya.
Nice catch - good to remove unused cruft.
Please prefix the subject with something like "drm/agp: ".
Check "git log" on the same file to pick up the usual way to identify
agp specific changes.
With this fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
You could also consider to add a few words in the body of the changelog
how the unused function was identified.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-08 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 17:40 [PATCH] Remove unused function drm_agp_bind_pages Maya Rashish
2019-07-08 8:18 ` Sam Ravnborg [this message]
2019-07-10 15:37 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708081816.GA27604@ravnborg.org \
--to=sam@ravnborg.org \
--cc=coypu@sdf.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.