From: Tejun Heo <tj@kernel.org>
To: Roman Gushchin <guro@fb.com>
Cc: Peng Wang <rocking@whu.edu.cn>,
"lizefan@huawei.com" <lizefan@huawei.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: minor tweak for logic to get cgroup css
Date: Mon, 8 Jul 2019 10:31:37 -0700 [thread overview]
Message-ID: <20190708173137.GH657710@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20190708172944.GA24662@tower.DHCP.thefacebook.com>
On Mon, Jul 08, 2019 at 05:29:49PM +0000, Roman Gushchin wrote:
> On Mon, Jul 08, 2019 at 09:42:43AM -0700, Tejun Heo wrote:
> > On Wed, Jul 03, 2019 at 10:07:49AM +0800, Peng Wang wrote:
> > > We could only handle the case that css exists
> > > and css_try_get_online() fails.
> >
> > As css_tryget_online() can't handle NULL input, this is a bug fix.
> > Can you please clarify that in the description?
>
> - if (!css || !css_tryget_online(css))
> + if (css && !css_tryget_online(css))
>
> If css == NULL, !css is true, and the second part of the || statement
> will not be evaluated. So it's not a bug fix.
Ah right, it's just confusing. Will apply after the merge window.
Thanks.
--
tejun
next prev parent reply other threads:[~2019-07-08 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 2:07 [PATCH] cgroup: minor tweak for logic to get cgroup css Peng Wang
2019-07-08 16:42 ` Tejun Heo
2019-07-08 17:29 ` Roman Gushchin
2019-07-08 17:31 ` Tejun Heo [this message]
2019-07-23 22:48 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708173137.GH657710@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rocking@whu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.