From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BFF5C606C9 for ; Mon, 8 Jul 2019 18:52:20 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 298DA21707 for ; Mon, 8 Jul 2019 18:52:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 298DA21707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id C32D62A83; Mon, 8 Jul 2019 18:52:19 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B9E442656 for ; Mon, 8 Jul 2019 18:43:54 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 50A24827 for ; Mon, 8 Jul 2019 18:43:54 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 8C7F2227A81; Mon, 8 Jul 2019 20:43:51 +0200 (CEST) Date: Mon, 8 Jul 2019 20:43:51 +0200 From: Christoph Hellwig To: Arend Van Spriel Subject: Re: use exact allocation for dma coherent memory Message-ID: <20190708184351.GA12877@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190701084833.GA22927@lst.de> <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Maxime Ripard , Joonas Lahtinen , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , linux-media@vger.kernel.org, Intel Linux Wireless , intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Jani Nikula , Ian Abbott , Rodrigo Vivi , Sean Paul , "moderated list:ARM PORT" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, H Hartley Sweeten , iommu@lists.linux-foundation.org, Daniel Vetter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Tue, Jul 02, 2019 at 11:48:44AM +0200, Arend Van Spriel wrote: > You made me look ;-) Actually not touching my drivers so I'm off the hook. > However, I was wondering if drivers could know so I decided to look into > the DMA-API.txt documentation which currently states: > > """ > The flag parameter (dma_alloc_coherent() only) allows the caller to > specify the ``GFP_`` flags (see kmalloc()) for the allocation (the > implementation may choose to ignore flags that affect the location of > the returned memory, like GFP_DMA). > """ > > I do expect you are going to change that description as well now that you > are going to issue a warning on __GFP_COMP. Maybe include that in patch > 15/16 where you introduce that warning. Yes, that description needs an updated, even without this series. I'll make sure it is more clear. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D47AEC606C7 for ; Mon, 8 Jul 2019 18:43:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B97BF217F4 for ; Mon, 8 Jul 2019 18:43:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730990AbfGHSnz (ORCPT ); Mon, 8 Jul 2019 14:43:55 -0400 Received: from verein.lst.de ([213.95.11.211]:35883 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728109AbfGHSny (ORCPT ); Mon, 8 Jul 2019 14:43:54 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8C7F2227A81; Mon, 8 Jul 2019 20:43:51 +0200 (CEST) Date: Mon, 8 Jul 2019 20:43:51 +0200 From: Christoph Hellwig To: Arend Van Spriel Cc: Christoph Hellwig , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Ian Abbott , H Hartley Sweeten , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Intel Linux Wireless , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, "moderated list:ARM PORT" , linux-media@vger.kernel.org Subject: Re: use exact allocation for dma coherent memory Message-ID: <20190708184351.GA12877@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190701084833.GA22927@lst.de> <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jul 02, 2019 at 11:48:44AM +0200, Arend Van Spriel wrote: > You made me look ;-) Actually not touching my drivers so I'm off the hook. > However, I was wondering if drivers could know so I decided to look into > the DMA-API.txt documentation which currently states: > > """ > The flag parameter (dma_alloc_coherent() only) allows the caller to > specify the ``GFP_`` flags (see kmalloc()) for the allocation (the > implementation may choose to ignore flags that affect the location of > the returned memory, like GFP_DMA). > """ > > I do expect you are going to change that description as well now that you > are going to issue a warning on __GFP_COMP. Maybe include that in patch > 15/16 where you introduce that warning. Yes, that description needs an updated, even without this series. I'll make sure it is more clear. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A623C606C7 for ; Mon, 8 Jul 2019 18:44:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32DCE216FD for ; Mon, 8 Jul 2019 18:44:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JZYA/Zew" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32DCE216FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Av8qn9Qr6QIZ44eDDFSm6JEp75V2K7Tf4bSzbueMvc=; b=JZYA/ZewOV4xQX dgd880XEWLJNn6YMmcyfCARKDWThvTwV6UO53rlR1ZAi2VPShkYravLMtYSnsfPhYurs08T7TzK5l 3VA7IIOEi+KdwVopJa2vNFOvKleoZNUTFWGMGr//Wm5bMtGGasrPXRewxOoI5Rso+JZhPNxsXAazV r65VVl+jUo1WCC9GTXTmzkMJgGU2vEJgCJqsBwLkoMYBRKHRwcqmMGK+YIBYoKJUTIyWCFvn8u3mu GjiYBLvswkLlLpWU0xjUUYM6z0i/APmLzv9aEkN+MQEr/ULkNQ3Fd6i/oAN2YPLD1p8y/jC0OYwOE wCxYXCVmlEqnVyi3amdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkYcK-0005qo-IC; Mon, 08 Jul 2019 18:44:00 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hkYcI-0005p1-3d for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2019 18:43:59 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 8C7F2227A81; Mon, 8 Jul 2019 20:43:51 +0200 (CEST) Date: Mon, 8 Jul 2019 20:43:51 +0200 From: Christoph Hellwig To: Arend Van Spriel Subject: Re: use exact allocation for dma coherent memory Message-ID: <20190708184351.GA12877@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190701084833.GA22927@lst.de> <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190708_114358_307032_7E9C0226 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Joonas Lahtinen , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , linux-media@vger.kernel.org, Intel Linux Wireless , intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Jani Nikula , Ian Abbott , Rodrigo Vivi , Sean Paul , "moderated list:ARM PORT" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, H Hartley Sweeten , iommu@lists.linux-foundation.org, Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 02, 2019 at 11:48:44AM +0200, Arend Van Spriel wrote: > You made me look ;-) Actually not touching my drivers so I'm off the hook. > However, I was wondering if drivers could know so I decided to look into > the DMA-API.txt documentation which currently states: > > """ > The flag parameter (dma_alloc_coherent() only) allows the caller to > specify the ``GFP_`` flags (see kmalloc()) for the allocation (the > implementation may choose to ignore flags that affect the location of > the returned memory, like GFP_DMA). > """ > > I do expect you are going to change that description as well now that you > are going to issue a warning on __GFP_COMP. Maybe include that in patch > 15/16 where you introduce that warning. Yes, that description needs an updated, even without this series. I'll make sure it is more clear. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: use exact allocation for dma coherent memory Date: Mon, 8 Jul 2019 20:43:51 +0200 Message-ID: <20190708184351.GA12877@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190701084833.GA22927@lst.de> <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <74eb9d99-6aa6-d1ad-e66d-6cc9c496b2f3@broadcom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arend Van Spriel Cc: Maxime Ripard , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , linux-media@vger.kernel.org, Intel Linux Wireless , intel-gfx@lists.freedesktop.org, Ian Abbott , "moderated list:ARM PORT" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, H Hartley Sweeten , iommu@lists.linux-foundation.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMDIsIDIwMTkgYXQgMTE6NDg6NDRBTSArMDIwMCwgQXJlbmQgVmFuIFNwcmll bCB3cm90ZToKPiBZb3UgbWFkZSBtZSBsb29rIDstKSBBY3R1YWxseSBub3QgdG91Y2hpbmcgbXkg ZHJpdmVycyBzbyBJJ20gb2ZmIHRoZSBob29rLiAKPiBIb3dldmVyLCBJIHdhcyB3b25kZXJpbmcg aWYgZHJpdmVycyBjb3VsZCBrbm93IHNvIEkgZGVjaWRlZCB0byBsb29rIGludG8gCj4gdGhlIERN QS1BUEkudHh0IGRvY3VtZW50YXRpb24gd2hpY2ggY3VycmVudGx5IHN0YXRlczoKPgo+ICIiIgo+ IFRoZSBmbGFnIHBhcmFtZXRlciAoZG1hX2FsbG9jX2NvaGVyZW50KCkgb25seSkgYWxsb3dzIHRo ZSBjYWxsZXIgdG8KPiBzcGVjaWZ5IHRoZSBgYEdGUF9gYCBmbGFncyAoc2VlIGttYWxsb2MoKSkg Zm9yIHRoZSBhbGxvY2F0aW9uICh0aGUKPiBpbXBsZW1lbnRhdGlvbiBtYXkgY2hvb3NlIHRvIGln bm9yZSBmbGFncyB0aGF0IGFmZmVjdCB0aGUgbG9jYXRpb24gb2YKPiB0aGUgcmV0dXJuZWQgbWVt b3J5LCBsaWtlIEdGUF9ETUEpLgo+ICIiIgo+Cj4gSSBkbyBleHBlY3QgeW91IGFyZSBnb2luZyB0 byBjaGFuZ2UgdGhhdCBkZXNjcmlwdGlvbiBhcyB3ZWxsIG5vdyB0aGF0IHlvdSAKPiBhcmUgZ29p bmcgdG8gaXNzdWUgYSB3YXJuaW5nIG9uIF9fR0ZQX0NPTVAuIE1heWJlIGluY2x1ZGUgdGhhdCBp biBwYXRjaCAKPiAxNS8xNiB3aGVyZSB5b3UgaW50cm9kdWNlIHRoYXQgd2FybmluZy4KClllcywg dGhhdCBkZXNjcmlwdGlvbiBuZWVkcyBhbiB1cGRhdGVkLCBldmVuIHdpdGhvdXQgdGhpcyBzZXJp ZXMuCkknbGwgbWFrZSBzdXJlIGl0IGlzIG1vcmUgY2xlYXIuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==