diff for duplicates of <20190708195532.GB5292@elm> diff --git a/a/1.txt b/N1/1.txt index a590a39..928de5b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -68,7 +68,7 @@ On 2019-07-05 18:37:35, Roberto Sassu wrote: > > ret = tpm_get_random(chip, digest, TPM_MAX_DIGEST_SIZE); > - if (ret < 0) -> + if (ret < 0 || ret = TPM_ERR_DEACTIVATED || ret = TPM_ERR_DISABLED) +> + if (ret < 0 || ret == TPM_ERR_DEACTIVATED || ret == TPM_ERR_DISABLED) > return ret; As someone who hasn't looked at much of the TPM code, I would have @@ -90,7 +90,7 @@ data. For instance, the way that tpm_hwrng_read() is calling tpm_get_random() looks a little worrisome. This patch would likely fix the bug reported against eCryptfs -(https://bugzilla.kernel.org/show_bug.cgi?id 3953) but I can't help to +(https://bugzilla.kernel.org/show_bug.cgi?id=203953) but I can't help to think that callers of tpm_get_random() would benefit from a more consolidated approach of handling TPM_ERR_* return values rather than handling them at this single call site. diff --git a/a/content_digest b/N1/content_digest index 9693bfa..396ff34 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020190705163735.11539-1-roberto.sassu@huawei.com\0" "From\0Tyler Hicks <tyhicks@canonical.com>\0" "Subject\0Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated\0" - "Date\0Mon, 08 Jul 2019 19:55:32 +0000\0" + "Date\0Mon, 8 Jul 2019 14:55:32 -0500\0" "To\0Roberto Sassu <roberto.sassu@huawei.com>\0" "Cc\0jarkko.sakkinen@linux.intel.com" jejb@linux.ibm.com @@ -86,7 +86,7 @@ "> \n" "> \tret = tpm_get_random(chip, digest, TPM_MAX_DIGEST_SIZE);\n" "> -\tif (ret < 0)\n" - "> +\tif (ret < 0 || ret = TPM_ERR_DEACTIVATED || ret = TPM_ERR_DISABLED)\n" + "> +\tif (ret < 0 || ret == TPM_ERR_DEACTIVATED || ret == TPM_ERR_DISABLED)\n" "> \t\treturn ret;\n" "\n" "As someone who hasn't looked at much of the TPM code, I would have\n" @@ -108,7 +108,7 @@ "tpm_get_random() looks a little worrisome.\n" "\n" "This patch would likely fix the bug reported against eCryptfs\n" - "(https://bugzilla.kernel.org/show_bug.cgi?id 3953) but I can't help to\n" + "(https://bugzilla.kernel.org/show_bug.cgi?id=203953) but I can't help to\n" "think that callers of tpm_get_random() would benefit from a more\n" "consolidated approach of handling TPM_ERR_* return values rather than\n" "handling them at this single call site.\n" @@ -121,4 +121,4 @@ "> 2.17.1\n" > -519a5064164e0d37e82dc5d12bec6ef259e8c63793e0dcdf81682285455e46a1 +c0831fe19f7c7bfe14318b79afaf68f6b66f3e3b8309c39c7fee9d8558149ff5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.