Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC

[Rob Herring <robh@kernel.org>]

On Mon, Jun 10, 2019 at 11:34:42AM +0300, Talel Shenhar wrote:
> Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding.
> 
> Signed-off-by: Talel Shenhar <talel@amazon.com>
> ---
>  .../interrupt-controller/amazon,al-fic.txt         | 29 ++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt
> new file mode 100644
> index 0000000..4e82fd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt
> @@ -0,0 +1,29 @@
> +Amazon's Annapurna Labs Fabric Interrupt Controller
> +
> +Required properties:
> +
> +- compatible: should be "amazon,al-fic"
> +- reg: physical base address and size of the registers
> +- interrupt-controller: identifies the node as an interrupt controller
> +- #interrupt-cells: must be 2.
> +  First cell defines the index of the interrupt within the controller.
> +  Second cell is used to specify the trigger type and must be one of the
> +  following:
> +    - bits[3:0] trigger type and level flags
> +	1 = low-to-high edge triggered
> +	4 = active high level-sensitive

No need to define this here. Reference the standard definition.

> +- interrupt-parent: specifies the parent interrupt controller.

Drop this. It is implied and could be in the parent.

> +- interrupts: describes which input line in the interrupt parent, this
> +  fic's output is connected to. This field property depends on the parent's
> +  binding
> +
> +Example:
> +
> +amazon_fic: interrupt-controller@0xfd8a8500 {

Drop the '0x'

> +	compatible = "amazon,al-fic";
> +	interrupt-controller;
> +	#interrupt-cells = <2>;
> +	reg = <0x0 0xfd8a8500 0x0 0x1000>;
> +	interrupt-parent = <&gic>;
> +	interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>;
> +};
> -- 
> 2.7.4
>