All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>,
	Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Subject: Re: [PATCH 3/3] mt76: usb: use full intermediate buffer in mt76u_copy
Date: Tue, 9 Jul 2019 12:12:24 +0200	[thread overview]
Message-ID: <20190709101223.GB3099@redhat.com> (raw)
In-Reply-To: <1562079961-15527-4-git-send-email-sgruszka@redhat.com>

On Tue, Jul 02, 2019 at 05:06:01PM +0200, Stanislaw Gruszka wrote:
> Instead of use several 4 bytes usb requests, use full 32 bytes buffer
> to copy data to device. With the change we use less requests and copy
> exact data size to the device regardless size is multiple of 4 or not.

And this does not work correctly on some usb hosts, request which
are not multiple of 4 do not ended being written to hardware, 
what results in original problem of having last part of beacon
corrupted.

I would prefer to drop this set - and I would post 2 patches
(first patch fixed and third dropped). But since this is now in
Felix's wireless tree I guess I need to post fixes on top of this
set?

Stanislaw

  reply	other threads:[~2019-07-09 10:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 15:05 [PATCH 0/3] mt76: usb: alignment and endianes improvements Stanislaw Gruszka
2019-07-02 15:05 ` [PATCH 1/3] mt76: usb: fix endian in mt76u_copy Stanislaw Gruszka
2019-07-09 10:06   ` Stanislaw Gruszka
2019-07-02 15:06 ` [PATCH 2/3] mt76: usb: remove unneeded {put,get}_unaligned Stanislaw Gruszka
2019-07-02 15:06 ` [PATCH 3/3] mt76: usb: use full intermediate buffer in mt76u_copy Stanislaw Gruszka
2019-07-09 10:12   ` Stanislaw Gruszka [this message]
2019-07-09 13:45     ` Felix Fietkau
2019-07-03 22:12 ` [PATCH 0/3] mt76: usb: alignment and endianes improvements Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709101223.GB3099@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.