From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DA7C73C46 for ; Tue, 9 Jul 2019 13:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3734820861 for ; Tue, 9 Jul 2019 13:01:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=jm0.eu header.i=@jm0.eu header.b="oMxG1mLA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726601AbfGINBb (ORCPT ); Tue, 9 Jul 2019 09:01:31 -0400 Received: from mo4-p05-ob.smtp.rzone.de ([85.215.255.135]:35864 "EHLO mo4-p05-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfGINBb (ORCPT ); Tue, 9 Jul 2019 09:01:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1562677289; s=strato-dkim-0002; d=jm0.eu; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=Q1qSEMgtA/+RfBYRIhji640wzqggiYGJGUbld0y/n5U=; b=oMxG1mLACR0D4VR/w5ueqgh5SAN+w8tNfBZfGP1kz8qh1uUUOBCU8W58YSmul/K+lV IMCi2X4WqcICs2OdjNwE8PEwG57400BamNaFSTBTwntR9VUXB5Z9YvpwJM4029LhhfAd o85XL59zydoFEXOgIhwaAA3ER5x7EIFxNxE6n1cRM4rI57i6rlrZYv6R4lD5lqKMsxWf D5E57xoHRvrlhIzN/2dZZtpazFd22mwmgQbYYiyGvuy/K8M7g2gtoP1FsY5g32u350S3 oO2FZtgTJ+IOnfC9YHqFlv/k46AkeSW7crNpazrAU6tEjiwlgmwwHF4zaDLZqQiYTbUR 07UA== X-RZG-AUTH: ":JmMXYEHmdv4HaV2cbPh7iS0wbr/uKIfGM0EPWe8EZQbw/dDJ/fVPBaXaSiaF5/mu26zWKwNU" X-RZG-CLASS-ID: mo05 Received: from linux-1tvp.lan by smtp.strato.de (RZmta 44.24 DYNA|AUTH) with ESMTPSA id h0a328v69D1OEgA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Tue, 9 Jul 2019 15:01:24 +0200 (CEST) From: josua@solid-run.com To: netdev@vger.kernel.org Cc: Josua Mayer , "David S. Miller" , Andrew Lunn Subject: [PATCH v2 3/4] net: mvmdio: print warning when orion-mdio has too many clocks Date: Tue, 9 Jul 2019 15:01:00 +0200 Message-Id: <20190709130101.5160-4-josua@solid-run.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190709130101.5160-1-josua@solid-run.com> References: <20190706151900.14355-1-josua@solid-run.com> <20190709130101.5160-1-josua@solid-run.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Josua Mayer Print a warning when device tree specifies more than the maximum of four clocks supported by orion-mdio. Because reading from mdio can lock up the Armada 8k when a required clock is not initialized, it is important to notify the user when a specified clock is ignored. Signed-off-by: Josua Mayer --- drivers/net/ethernet/marvell/mvmdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index e17d563e97a6..eba18065a4da 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -326,6 +326,10 @@ static int orion_mdio_probe(struct platform_device *pdev) clk_prepare_enable(dev->clk[i]); } + if (!IS_ERR(of_clk_get(pdev->dev.of_node, ARRAY_SIZE(dev->clk)))) + dev_warn(&pdev->dev, "unsupported number of clocks, limiting to the first " + __stringify(ARRAY_SIZE(dev->clk)) "\n"); + dev->err_interrupt = platform_get_irq(pdev, 0); if (dev->err_interrupt > 0 && resource_size(r) < MVMDIO_ERR_INT_MASK + 4) { -- 2.16.4