From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3C5C73C46 for ; Tue, 9 Jul 2019 15:10:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88758216C4 for ; Tue, 9 Jul 2019 15:10:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88758216C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45jm390mr0zDqb5 for ; Wed, 10 Jul 2019 01:10:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45jm1Q1yFpzDqT2 for ; Wed, 10 Jul 2019 01:08:57 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id 6265768B02; Tue, 9 Jul 2019 17:08:53 +0200 (CEST) Date: Tue, 9 Jul 2019 17:08:53 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 1/3] powerpc/powernv: remove the unused pnv_pci_set_p2p function Message-ID: <20190709150853.GA3872@lst.de> References: <20190426124917.23789-2-hch@lst.de> <99c4c4a9-8a18-61ed-174a-9ffaec3d2e44@linux.ibm.com> <20190523075253.GA12946@lst.de> <20190709135935.GA2511@lst.de> <20190709143251.GA3222@lst.de> <20190709144049.GA3364@lst.de> <14dee448-94bc-aaea-3661-baa92ac8c2f8@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14dee448-94bc-aaea-3661-baa92ac8c2f8@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "'gregkh@linuxfoundation.org'" , Shlomi Nimrodi , Paul Mackerras , Bodong Wang , Frederic Barrat , Oren Duer , Idan Werpoler , "linuxppc-dev@lists.ozlabs.org" , Christoph Hellwig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 09, 2019 at 06:06:54PM +0300, Max Gurtovoy wrote: > Also this code was merged before the p2p API for p2pmem. Yes, without a single user or intention to submit a user, and without covering the most useful use case (PCIe switches). While at the same time the people involved completely ignored the PCIe P2P discussions that have been going on the PCI list for a long time. This is a text book example of why code needs to be upstream first with a broad discussion instead of slipping some crap in for out of tree drivers.