From: Guenter Roeck <linux@roeck-us.net>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
"kernelci . org bot" <bot@kernelci.org>
Subject: Re: [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe
Date: Tue, 9 Jul 2019 14:00:46 -0700 [thread overview]
Message-ID: <20190709210046.GA29377@roeck-us.net> (raw)
In-Reply-To: <20190709203409.117123-1-natechancellor@gmail.com>
On Tue, Jul 09, 2019 at 01:34:09PM -0700, Nathan Chancellor wrote:
> clang warns:
>
> drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret'
> [-Wunused-variable]
> int ret;
> ^
> 1 warning generated.
>
> It's unused now, remove it.
>
> Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering device")
> Link: https://github.com/ClangBuiltLinux/linux/issues/591
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/digicolor_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95bd238..073d37867f47 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dc_wdt *wdt;
> - int ret;
>
> wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
> if (!wdt)
> --
> 2.22.0
>
next prev parent reply other threads:[~2019-07-09 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 20:34 [PATCH] watchdog: digicolor_wdt: Remove unused variable in dc_wdt_probe Nathan Chancellor
2019-07-09 21:00 ` Guenter Roeck [this message]
2019-07-18 16:41 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709210046.GA29377@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bot@kernelci.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.