From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 10/25] drm/i915/tgl: Add power well to support 4th pipe Date: Wed, 10 Jul 2019 04:04:29 -0700 Message-ID: <20190710110429.GK16315@intel.com> References: <20190708231629.9296-1-lucas.demarchi@intel.com> <20190708231629.9296-11-lucas.demarchi@intel.com> <20190709115732.GC16315@intel.com> <20190709162042.okv75ozrvplii7tk@ldmartin-desk1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30F9189F2E for ; Wed, 10 Jul 2019 11:03:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190709162042.okv75ozrvplii7tk@ldmartin-desk1> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgMDksIDIwMTkgYXQgMDk6MjA6NDJBTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE9uIFR1ZSwgSnVsIDA5LCAyMDE5IGF0IDA0OjU3OjMyQU0gLTA3MDAsIFJvZHJp Z28gVml2aSB3cm90ZToKPiA+IE9uIE1vbiwgSnVsIDA4LCAyMDE5IGF0IDA0OjE2OjE0UE0gLTA3 MDAsIEx1Y2FzIERlIE1hcmNoaSB3cm90ZToKPiA+ID4gRnJvbTogTWlrYSBLYWhvbGEgPG1pa2Eu a2Fob2xhQGludGVsLmNvbT4KPiA+ID4gCj4gPiA+IEFkZCBwb3dlciB3ZWxsIDUgdG8gc3VwcG9y dCA0dGggcGlwZSBhbmQgdHJhbnNjb2RlciBvbiBUR0wuCj4gPiA+IAo+ID4gPiBDYzogSmFtZXMg QXVzbXVzIDxqYW1lcy5hdXNtdXNAaW50ZWwuY29tPgo+ID4gPiBDYzogSW1yZSBEZWFrIDxpbXJl LmRlYWtAaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNaWthIEthaG9sYSA8bWlrYS5r YWhvbGFAaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1 Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICAuLi4vZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kaXNwbGF5X3Bvd2VyLmMgICAgfCAzMCArKysrKysrKysrKysrKysrLS0tCj4g PiA+ICAuLi4vZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5X3Bvd2VyLmggICAgfCAgMyAr Kwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgICAgICAgICAgICAgIHwg IDMgKy0KPiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlv bnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2Rpc3BsYXlfcG93ZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfZGlzcGxheV9wb3dlci5jCj4gPiA+IGluZGV4IGMzZjQyMTY5ODMxZi4uNDU1ZjlhYWIx ODhkIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVs X2Rpc3BsYXlfcG93ZXIuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5 L2ludGVsX2Rpc3BsYXlfcG93ZXIuYwo+ID4gPiBAQCAtMzcsMTggKzM3LDI0IEBAIGludGVsX2Rp c3BsYXlfcG93ZXJfZG9tYWluX3N0cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiA+ ID4gIAkJcmV0dXJuICJQSVBFX0IiOwo+ID4gPiAgCWNhc2UgUE9XRVJfRE9NQUlOX1BJUEVfQzoK PiA+ID4gIAkJcmV0dXJuICJQSVBFX0MiOwo+ID4gPiArCWNhc2UgUE9XRVJfRE9NQUlOX1BJUEVf RDoKPiA+ID4gKwkJcmV0dXJuICJQSVBFX0QiOwo+ID4gPiAgCWNhc2UgUE9XRVJfRE9NQUlOX1BJ UEVfQV9QQU5FTF9GSVRURVI6Cj4gPiA+ICAJCXJldHVybiAiUElQRV9BX1BBTkVMX0ZJVFRFUiI7 Cj4gPiA+ICAJY2FzZSBQT1dFUl9ET01BSU5fUElQRV9CX1BBTkVMX0ZJVFRFUjoKPiA+ID4gIAkJ cmV0dXJuICJQSVBFX0JfUEFORUxfRklUVEVSIjsKPiA+ID4gIAljYXNlIFBPV0VSX0RPTUFJTl9Q SVBFX0NfUEFORUxfRklUVEVSOgo+ID4gPiAgCQlyZXR1cm4gIlBJUEVfQ19QQU5FTF9GSVRURVIi Owo+ID4gPiArCWNhc2UgUE9XRVJfRE9NQUlOX1BJUEVfRF9QQU5FTF9GSVRURVI6Cj4gPiA+ICsJ CXJldHVybiAiUElQRV9EX1BBTkVMX0ZJVFRFUiI7Cj4gPiA+ICAJY2FzZSBQT1dFUl9ET01BSU5f VFJBTlNDT0RFUl9BOgo+ID4gPiAgCQlyZXR1cm4gIlRSQU5TQ09ERVJfQSI7Cj4gPiA+ICAJY2Fz ZSBQT1dFUl9ET01BSU5fVFJBTlNDT0RFUl9COgo+ID4gPiAgCQlyZXR1cm4gIlRSQU5TQ09ERVJf QiI7Cj4gPiA+ICAJY2FzZSBQT1dFUl9ET01BSU5fVFJBTlNDT0RFUl9DOgo+ID4gPiAgCQlyZXR1 cm4gIlRSQU5TQ09ERVJfQyI7Cj4gPiA+ICsJY2FzZSBQT1dFUl9ET01BSU5fVFJBTlNDT0RFUl9E Ogo+ID4gPiArCQlyZXR1cm4gIlRSQU5TQ09ERVJfRCI7Cj4gPiA+ICAJY2FzZSBQT1dFUl9ET01B SU5fVFJBTlNDT0RFUl9FRFA6Cj4gPiA+ICAJCXJldHVybiAiVFJBTlNDT0RFUl9FRFAiOwo+ID4g PiAgCWNhc2UgUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVJfRURQX1ZEU0M6Cj4gPiA+IEBAIC0yNDUx LDcgKzI0NTcsNiBAQCB2b2lkIGludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gICAqIC0gRERJX0EKPiA+ID4gICAqIC0gRkJDCj4g PiA+ICAgKi8KPiA+ID4gLS8qIFRPRE86IFRHTF9QV181X1BPV0VSX0RPTUFJTlM6IFBJUEVfRCAq Lwo+ID4gPiAgI2RlZmluZSBJQ0xfUFdfNF9QT1dFUl9ET01BSU5TICgJCQlcCj4gPiA+ICAJQklU X1VMTChQT1dFUl9ET01BSU5fUElQRV9DKSB8CQkJXAo+ID4gPiAgCUJJVF9VTEwoUE9XRVJfRE9N QUlOX1BJUEVfQ19QQU5FTF9GSVRURVIpIHwJXAo+ID4gPiBAQCAtMjUzOSw3ICsyNTQ0LDEzIEBA IHZvaWQgaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LAo+ID4gPiAgI2RlZmluZSBJQ0xfQVVYX1RCVDRfSU9fUE9XRVJfRE9NQUlOUyAoCQkJ XAo+ID4gPiAgCUJJVF9VTEwoUE9XRVJfRE9NQUlOX0FVWF9UQlQ0KSkKPiA+ID4gCj4gPiA+ICsj ZGVmaW5lIFRHTF9QV181X1BPV0VSX0RPTUFJTlMgKAkJCVwKPiA+ID4gKwlCSVRfVUxMKFBPV0VS X0RPTUFJTl9QSVBFX0QpIHwJCQlcCj4gPiA+ICsJQklUX1VMTChQT1dFUl9ET01BSU5fUElQRV9E X1BBTkVMX0ZJVFRFUikgfCAgICAgXAo+ID4gPiArCUJJVF9VTEwoUE9XRVJfRE9NQUlOX0lOSVQp KQo+ID4gPiArCj4gPiA+ICAjZGVmaW5lIFRHTF9QV180X1BPV0VSX0RPTUFJTlMgKAkJCVwKPiA+ ID4gKwlUR0xfUFdfNV9QT1dFUl9ET01BSU5TIHwJCQlcCj4gPiAKPiA+IHdoeT8KPiAKPiBub3Qg c3VyZSBJIHVuZGVyc3RhbmQgdGhpcyBvbmUuIEFyZSB5b3Ugc2F5aW5nIHdlIHNob3VsZG4ndCBo YXZlIGEgbmV3Cj4gcG93ZXIgd2VsbCBmb3IgcGlwZSBkPyBIb3cgd291bGQgd2UgaGFuZGxlIHRo ZSBkaWZmZXJlbnQgY3RsPwoKV2Ugc2hvdWxkIGhhdmUgYSBuZXcgb25lLiBUaGUgYWJvdmUgYmxv Y2sgd2hvIGFkZHMgUFc1IGRvbWFpbnMgaXMgb2theS4KV2hhdCBJIGRpZG4ndCB1bmRlcnN0YW5k IGlzIHdoeSB0byBhZGQgcGlwZSBEIGFsc28gb24gUFc0Cgo+IAo+ID4gCj4gPiA+ICAJQklUX1VM TChQT1dFUl9ET01BSU5fUElQRV9DKSB8CQkJXAo+ID4gPiAgCUJJVF9VTEwoUE9XRVJfRE9NQUlO X1BJUEVfQ19QQU5FTF9GSVRURVIpIHwJXAo+ID4gPiAgCUJJVF9VTEwoUE9XRVJfRE9NQUlOX0lO SVQpKQo+ID4gPiBAQCAtMjU0OSw3ICsyNTYwLDcgQEAgdm9pZCBpbnRlbF9kaXNwbGF5X3Bvd2Vy X3B1dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ICAJQklUX1VMTChQ T1dFUl9ET01BSU5fUElQRV9CKSB8CQkJXAo+ID4gPiAgCUJJVF9VTEwoUE9XRVJfRE9NQUlOX1RS QU5TQ09ERVJfQikgfAkJXAo+ID4gPiAgCUJJVF9VTEwoUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVJf QykgfAkJXAo+ID4gPiAtCS8qIFRPRE86IFRSQU5TQ09ERVJfRCAqLwkJCVwKPiA+ID4gKwlCSVRf VUxMKFBPV0VSX0RPTUFJTl9UUkFOU0NPREVSX0QpIHwJCVwKPiA+ID4gIAlCSVRfVUxMKFBPV0VS X0RPTUFJTl9QSVBFX0JfUEFORUxfRklUVEVSKSB8CVwKPiA+ID4gIAlCSVRfVUxMKFBPV0VSX0RP TUFJTl9QT1JUX0RESV9UQzFfTEFORVMpIHwJXAo+ID4gPiAgCUJJVF9VTEwoUE9XRVJfRE9NQUlO X1BPUlRfRERJX1RDMV9JTykgfAkJXAo+ID4gPiBAQCAtMzg4Miw3ICszODkzLDcgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBpOTE1X3Bvd2VyX3dlbGxfZGVzYyB0Z2xfcG93ZXJfd2VsbHNbXSA9IHsK PiA+ID4gIAl9LAo+ID4gPiAgCXsKPiA+ID4gIAkJLm5hbWUgPSAicG93ZXIgd2VsbCA0IiwKPiA+ ID4gLQkJLmRvbWFpbnMgPSBJQ0xfUFdfNF9QT1dFUl9ET01BSU5TLAo+ID4gPiArCQkuZG9tYWlu cyA9IFRHTF9QV180X1BPV0VSX0RPTUFJTlMsCj4gPiAKPiA+IHdoeT8KPiAKPiB0aGlzIGlzIGEg bGVmdG92ZXIgZnJvbSB2MSBhbmQgc2hvdWxkIGJlIHNxdWFzaGVkIG9uIHByZXZpb3VzIHBhdGNo LCBteQo+IGJhZC4gSW4gdjEgd2Ugd2VyZSByZXVzaW5nIHRoZSBJQ0wgZGVmaW5pdGlvbnMuIEkg Y2hhbmdlZCBpbiB0aGlzCj4gcmV2aXNpb24gYW5kIGZvcmdvdCB0byBzcXVhc2ggdGhpcyBjaGFu Z2UgdGhlcmUuIEkgd2lsbCBzZW5kIGEgbmV3Cj4gdmVyc2lvbgo+IAo+IHRoYW5rcwo+IAo+IEx1 Y2FzIERlIE1hcmNoaQo+IAo+ID4gCj4gPiA+ICAJCS5vcHMgPSAmaHN3X3Bvd2VyX3dlbGxfb3Bz LAo+ID4gPiAgCQkuaWQgPSBESVNQX1BXX0lEX05PTkUsCj4gPiA+ICAJCXsKPiA+ID4gQEAgLTM4 OTIsNyArMzkwMywxOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGk5MTVfcG93ZXJfd2VsbF9kZXNj IHRnbF9wb3dlcl93ZWxsc1tdID0gewo+ID4gPiAgCQkJLmhzdy5pcnFfcGlwZV9tYXNrID0gQklU KFBJUEVfQyksCj4gPiA+ICAJCX0KPiA+ID4gIAl9LAo+ID4gPiAtCS8qIFRPRE86IHBvd2VyIHdl bGwgNSBmb3IgcGlwZSBEICovCj4gPiA+ICsJewo+ID4gPiArCQkubmFtZSA9ICJwb3dlciB3ZWxs IDUiLAo+ID4gPiArCQkuZG9tYWlucyA9IFRHTF9QV181X1BPV0VSX0RPTUFJTlMsCj4gPiA+ICsJ CS5vcHMgPSAmaHN3X3Bvd2VyX3dlbGxfb3BzLAo+ID4gPiArCQkuaWQgPSBESVNQX1BXX0lEX05P TkUsCj4gPiA+ICsJCXsKPiA+ID4gKwkJCS5oc3cucmVncyA9ICZoc3dfcG93ZXJfd2VsbF9yZWdz LAo+ID4gPiArCQkJLmhzdy5pZHggPSBUR0xfUFdfQ1RMX0lEWF9QV181LAo+ID4gPiArCQkJLmhz dy5oYXNfZnVzZXMgPSB0cnVlLAo+ID4gPiArCQkJLmhzdy5pcnFfcGlwZV9tYXNrID0gQklUKFBJ UEVfRCksCj4gPiA+ICsJCX0sCj4gPiA+ICsJfSwKPiA+ID4gIH07Cj4gPiA+IAo+ID4gPiAgc3Rh dGljIGludAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF9kaXNwbGF5X3Bvd2VyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVs X2Rpc3BsYXlfcG93ZXIuaAo+ID4gPiBpbmRleCA4NmFmZDcwYzFmYjIuLmViYjM5N2UzMzBlYSAx MDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNw bGF5X3Bvd2VyLmgKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9kaXNwbGF5X3Bvd2VyLmgKPiA+ID4gQEAgLTE4LDEyICsxOCwxNSBAQCBlbnVtIGludGVsX2Rp c3BsYXlfcG93ZXJfZG9tYWluIHsKPiA+ID4gIAlQT1dFUl9ET01BSU5fUElQRV9BLAo+ID4gPiAg CVBPV0VSX0RPTUFJTl9QSVBFX0IsCj4gPiA+ICAJUE9XRVJfRE9NQUlOX1BJUEVfQywKPiA+ID4g KwlQT1dFUl9ET01BSU5fUElQRV9ELAo+ID4gPiAgCVBPV0VSX0RPTUFJTl9QSVBFX0FfUEFORUxf RklUVEVSLAo+ID4gPiAgCVBPV0VSX0RPTUFJTl9QSVBFX0JfUEFORUxfRklUVEVSLAo+ID4gPiAg CVBPV0VSX0RPTUFJTl9QSVBFX0NfUEFORUxfRklUVEVSLAo+ID4gPiArCVBPV0VSX0RPTUFJTl9Q SVBFX0RfUEFORUxfRklUVEVSLAo+ID4gPiAgCVBPV0VSX0RPTUFJTl9UUkFOU0NPREVSX0EsCj4g PiA+ICAJUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVJfQiwKPiA+ID4gIAlQT1dFUl9ET01BSU5fVFJB TlNDT0RFUl9DLAo+ID4gPiArCVBPV0VSX0RPTUFJTl9UUkFOU0NPREVSX0QsCj4gPiA+ICAJUE9X RVJfRE9NQUlOX1RSQU5TQ09ERVJfRURQLAo+ID4gPiAgCVBPV0VSX0RPTUFJTl9UUkFOU0NPREVS X0VEUF9WRFNDLAo+ID4gPiAgCVBPV0VSX0RPTUFJTl9UUkFOU0NPREVSX0RTSV9BLAo+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4gaW5kZXggZjU5Y2I1YzQ1YzM0Li41Y2E3NGVjYTA1 YTQgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiBAQCAtOTE0Nyw3 ICs5MTQ3LDggQEAgZW51bSB7Cj4gPiA+ICAjZGVmaW5lICAgR0xLX1BXX0NUTF9JRFhfRERJX0EJ CQkxCj4gPiA+ICAjZGVmaW5lICAgU0tMX1BXX0NUTF9JRFhfTUlTQ19JTwkJMAo+ID4gPiAKPiA+ ID4gLS8qIElDTCAtIHBvd2VyIHdlbGxzICovCj4gPiA+ICsvKiBJQ0wvVEdMIC0gcG93ZXIgd2Vs bHMgKi8KPiA+ID4gKyNkZWZpbmUgICBUR0xfUFdfQ1RMX0lEWF9QV181CQkJNAo+ID4gPiAgI2Rl ZmluZSAgIElDTF9QV19DVExfSURYX1BXXzQJCQkzCj4gPiA+ICAjZGVmaW5lICAgSUNMX1BXX0NU TF9JRFhfUFdfMwkJCTIKPiA+ID4gICNkZWZpbmUgICBJQ0xfUFdfQ1RMX0lEWF9QV18yCQkJMQo+ ID4gPiAtLQo+ID4gPiAyLjIxLjAKPiA+ID4gCj4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=