From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Zhang Yang <w90p710@gmail.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH] KVM: x86: Fix guest time accounting with VIRT_CPU_ACCOUNTING_GEN
Date: Wed, 10 Jul 2019 09:05:44 -0700 [thread overview]
Message-ID: <20190710160544.GB4348@linux.intel.com> (raw)
In-Reply-To: <CANwVFYMwKqsvGhPS7ZpQRS-dJ58KMLRSx8oEk_PowMtwpfXK=A@mail.gmail.com>
On Wed, Jul 10, 2019 at 08:42:30PM +0800, Zhang Yang wrote:
> Yes, In fact we had a trouble with the small window, the system monitor
> found that the host machine's sys is very high now and then. Based on our's
> tracing, we found that timer interrupt always hit after local_irq_enable, the
> guest tick would be always accounted to system time. after applying this
> patch, the phenomenon disappears.
Fun. Rather than switching to guest_exit(), I think it'd be better to
unconditionally open an irq window in order to minimize the overhead.
I'll send a patch, it's easier to explain with code :-)
prev parent reply other threads:[~2019-07-10 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 16:47 [PATCH] KVM: x86: Fix guest time accounting with VIRT_CPU_ACCOUNTING_GEN Wei Yang
2019-07-09 14:56 ` Sean Christopherson
[not found] ` <CANwVFYMwKqsvGhPS7ZpQRS-dJ58KMLRSx8oEk_PowMtwpfXK=A@mail.gmail.com>
2019-07-10 16:05 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710160544.GB4348@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=w90p710@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.