From: Nathan Chancellor <natechancellor@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] acpi: blacklist: fix clang warning for unused dmi table
Date: Wed, 10 Jul 2019 10:09:53 -0700 [thread overview]
Message-ID: <20190710170953.GA80585@archlinux-threadripper> (raw)
In-Reply-To: <20190710130555.1829974-1-arnd@arndb.de>
On Wed, Jul 10, 2019 at 03:05:43PM +0200, Arnd Bergmann wrote:
> When CONFIG_DMI is disabled, we only have a tentative declaration,
> which causes a warning from clang:
>
> drivers/acpi/blacklist.c:20:35: error: tentative array definition assumed to have one element [-Werror]
> static const struct dmi_system_id acpi_rev_dmi_table[] __initconst;
>
> As the variable is not actually used here, hide it entirely
> in an #ifdef to shut up the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
next prev parent reply other threads:[~2019-07-10 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 13:05 [PATCH] acpi: blacklist: fix clang warning for unused dmi table Arnd Bergmann
2019-07-10 17:09 ` Nathan Chancellor [this message]
2019-07-18 8:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710170953.GA80585@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.