From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 17/25] drm/i915/tgl: select correct bit for port select Date: Wed, 10 Jul 2019 21:40:05 +0300 Message-ID: <20190710184005.GJ5942@intel.com> References: <20190708231629.9296-1-lucas.demarchi@intel.com> <20190708231629.9296-18-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1D686E109 for ; Wed, 10 Jul 2019 18:40:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190708231629.9296-18-lucas.demarchi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdWwgMDgsIDIwMTkgYXQgMDQ6MTY6MjFQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IEZyb206IE1haGVzaCBLdW1hciA8bWFoZXNoMS5rdW1hckBpbnRlbC5jb20+Cj4g Cj4gQml0IGRlZmluaXRpb25zIGZvciBwb3J0LXNlbGVjdCBnb3QgY2hhbmdlZCBmb3IgVFJBTlNf Q0xLX1NFTCAmCj4gVFJBTlNfRERJX0ZVTkNfQ1RMIHJlZ2lzdGVycyBpbiBUR0wuCj4gCj4gU2ln bmVkLW9mZi1ieTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kZGkuYyB8IDQ4ICsrKysr KysrKysrKysrKysrKystLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAg ICAgICAgIHwgIDUgKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwgMTAg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3Bs YXkvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RkaS5j Cj4gaW5kZXggZTcyY2YwYmI0OGE3Li41MTI1YzMxYWY2YWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGRpLmMKPiBAQCAtMTc3MSw3ICsxNzcxLDEwIEBAIHZvaWQg aW50ZWxfZGRpX2VuYWJsZV90cmFuc2NvZGVyX2Z1bmMoY29uc3Qgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4gIAo+ICAJLyogRW5hYmxlIFRSQU5TX0RESV9GVU5DX0NUTCBm b3IgdGhlIHBpcGUgdG8gd29yayBpbiBIRE1JIG1vZGUgKi8KPiAgCXRlbXAgPSBUUkFOU19ERElf RlVOQ19FTkFCTEU7Cj4gLQl0ZW1wIHw9IFRSQU5TX0RESV9TRUxFQ1RfUE9SVChwb3J0KTsKPiAr CWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDEyKQo+ICsJCXRlbXAgfD0gVEdMX1RSQU5TX0RE SV9TRUxFQ1RfUE9SVChwb3J0KTsKPiArCWVsc2UKPiArCQl0ZW1wIHw9IFRSQU5TX0RESV9TRUxF Q1RfUE9SVChwb3J0KTsKPiAgCj4gIAlzd2l0Y2ggKGNydGNfc3RhdGUtPnBpcGVfYnBwKSB7Cj4g IAljYXNlIDE4Ogo+IEBAIC0xODUxLDggKzE4NTQsMTQgQEAgdm9pZCBpbnRlbF9kZGlfZGlzYWJs ZV90cmFuc2NvZGVyX2Z1bmMoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3Rh dGUKPiAgCWk5MTVfcmVnX3QgcmVnID0gVFJBTlNfRERJX0ZVTkNfQ1RMKGNwdV90cmFuc2NvZGVy KTsKPiAgCXUzMiB2YWwgPSBJOTE1X1JFQUQocmVnKTsKPiAgCj4gLQl2YWwgJj0gfihUUkFOU19E RElfRlVOQ19FTkFCTEUgfCBUUkFOU19ERElfUE9SVF9NQVNLIHwgVFJBTlNfRERJX0RQX1ZDX1BB WUxPQURfQUxMT0MpOwo+IC0JdmFsIHw9IFRSQU5TX0RESV9QT1JUX05PTkU7Cj4gKwlpZiAoSU5U RUxfR0VOKGRldl9wcml2KSA+PSAxMikgewo+ICsJCXZhbCAmPSB+KFRSQU5TX0RESV9GVU5DX0VO QUJMRSB8IFRHTF9UUkFOU19ERElfUE9SVF9NQVNLIHwKPiArCQkJIFRSQU5TX0RESV9EUF9WQ19Q QVlMT0FEX0FMTE9DKTsKPiArCX0gZWxzZSB7Cj4gKwkJdmFsICY9IH4oVFJBTlNfRERJX0ZVTkNf RU5BQkxFIHwgVFJBTlNfRERJX1BPUlRfTUFTSyB8Cj4gKwkJCSBUUkFOU19ERElfRFBfVkNfUEFZ TE9BRF9BTExPQyk7Cj4gKwkJdmFsIHw9IFRSQU5TX0RESV9QT1JUX05PTkU7CgpBIGJpdCBpbmNv c2lzdGVudCBsZWF2aW5nIHRoZSBOT05FIHRoaW5nIGhlcmUuIE1heWJlIGp1c3QgbnVrZSB0aGF0 CmVudGlyZWx5PwoKUGF0Y2ggaXMKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICsJfQo+ICAJSTkxNV9XUklURShyZWcsIHZhbCk7 Cj4gIAo+ICAJaWYgKGRldl9wcml2LT5xdWlya3MgJiBRVUlSS19JTkNSRUFTRV9ERElfRElTQUJM RURfVElNRSAmJgo+IEBAIC0yMDA0LDEwICsyMDEzLDE5IEBAIHN0YXRpYyB2b2lkIGludGVsX2Rk aV9nZXRfZW5jb2Rlcl9waXBlcyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCW1z dF9waXBlX21hc2sgPSAwOwo+ICAJZm9yX2VhY2hfcGlwZShkZXZfcHJpdiwgcCkgewo+ICAJCWVu dW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IChlbnVtIHRyYW5zY29kZXIpcDsKPiArCQl1 bnNpZ25lZCBpbnQgcG9ydF9tYXNrLCBkZGlfc2VsZWN0Owo+ICsKPiArCQlpZiAoSU5URUxfR0VO KGRldl9wcml2KSA+PSAxMikgewo+ICsJCQlwb3J0X21hc2sgPSBUR0xfVFJBTlNfRERJX1BPUlRf TUFTSzsKPiArCQkJZGRpX3NlbGVjdCA9IFRHTF9UUkFOU19ERElfU0VMRUNUX1BPUlQocG9ydCk7 Cj4gKwkJfSBlbHNlIHsKPiArCQkJcG9ydF9tYXNrID0gVFJBTlNfRERJX1BPUlRfTUFTSzsKPiAr CQkJZGRpX3NlbGVjdCA9IFRSQU5TX0RESV9TRUxFQ1RfUE9SVChwb3J0KTsKPiArCQl9Cj4gIAo+ ICAJCXRtcCA9IEk5MTVfUkVBRChUUkFOU19ERElfRlVOQ19DVEwoY3B1X3RyYW5zY29kZXIpKTsK PiAgCj4gLQkJaWYgKCh0bXAgJiBUUkFOU19ERElfUE9SVF9NQVNLKSAhPSBUUkFOU19ERElfU0VM RUNUX1BPUlQocG9ydCkpCj4gKwkJaWYgKCh0bXAgJiBwb3J0X21hc2spICE9IGRkaV9zZWxlY3Qp Cj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAgCQlpZiAoKHRtcCAmIFRSQU5TX0RESV9NT0RFX1NFTEVD VF9NQVNLKSA9PQo+IEBAIC0yMTIzLDkgKzIxNDEsMTQgQEAgdm9pZCBpbnRlbF9kZGlfZW5hYmxl X3BpcGVfY2xvY2soY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4g IAllbnVtIHBvcnQgcG9ydCA9IGVuY29kZXItPnBvcnQ7Cj4gIAllbnVtIHRyYW5zY29kZXIgY3B1 X3RyYW5zY29kZXIgPSBjcnRjX3N0YXRlLT5jcHVfdHJhbnNjb2RlcjsKPiAgCj4gLQlpZiAoY3B1 X3RyYW5zY29kZXIgIT0gVFJBTlNDT0RFUl9FRFApCj4gLQkJSTkxNV9XUklURShUUkFOU19DTEtf U0VMKGNwdV90cmFuc2NvZGVyKSwKPiAtCQkJICAgVFJBTlNfQ0xLX1NFTF9QT1JUKHBvcnQpKTsK PiArCWlmIChjcHVfdHJhbnNjb2RlciAhPSBUUkFOU0NPREVSX0VEUCkgewo+ICsJCWlmIChJTlRF TF9HRU4oZGV2X3ByaXYpID49IDEyKQo+ICsJCQlJOTE1X1dSSVRFKFRSQU5TX0NMS19TRUwoY3B1 X3RyYW5zY29kZXIpLAo+ICsJCQkJICAgVEdMX1RSQU5TX0NMS19TRUxfUE9SVChwb3J0KSk7Cj4g KwkJZWxzZQo+ICsJCQlJOTE1X1dSSVRFKFRSQU5TX0NMS19TRUwoY3B1X3RyYW5zY29kZXIpLAo+ ICsJCQkJICAgVFJBTlNfQ0xLX1NFTF9QT1JUKHBvcnQpKTsKPiArCX0KPiAgfQo+ICAKPiAgdm9p ZCBpbnRlbF9kZGlfZGlzYWJsZV9waXBlX2Nsb2NrKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlKQo+IEBAIC0yMTMzLDkgKzIxNTYsMTQgQEAgdm9pZCBpbnRlbF9kZGlf ZGlzYWJsZV9waXBlX2Nsb2NrKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlKQo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRj X3N0YXRlLT5iYXNlLmNydGMtPmRldik7Cj4gIAllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29k ZXIgPSBjcnRjX3N0YXRlLT5jcHVfdHJhbnNjb2RlcjsKPiAgCj4gLQlpZiAoY3B1X3RyYW5zY29k ZXIgIT0gVFJBTlNDT0RFUl9FRFApCj4gLQkJSTkxNV9XUklURShUUkFOU19DTEtfU0VMKGNwdV90 cmFuc2NvZGVyKSwKPiAtCQkJICAgVFJBTlNfQ0xLX1NFTF9ESVNBQkxFRCk7Cj4gKwlpZiAoY3B1 X3RyYW5zY29kZXIgIT0gVFJBTlNDT0RFUl9FRFApIHsKPiArCQlpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSAxMikKPiArCQkJSTkxNV9XUklURShUUkFOU19DTEtfU0VMKGNwdV90cmFuc2NvZGVy KSwKPiArCQkJCSAgIFRHTF9UUkFOU19DTEtfU0VMX0RJU0FCTEVEKTsKPiArCQllbHNlCj4gKwkJ CUk5MTVfV1JJVEUoVFJBTlNfQ0xLX1NFTChjcHVfdHJhbnNjb2RlciksCj4gKwkJCQkgICBUUkFO U19DTEtfU0VMX0RJU0FCTEVEKTsKPiArCX0KPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgX3NrbF9k ZGlfc2V0X2lib29zdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggYzU1NGRmNjlmMjg5Li5jY2ZiOTVlMmFhMDMgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtOTM3OSw4ICs5Mzc5LDEwIEBAIGVudW0gc2ts X3Bvd2VyX2dhdGUgewo+ICAjZGVmaW5lICBUUkFOU19ERElfRlVOQ19FTkFCTEUJCSgxIDw8IDMx KQo+ICAvKiBUaG9zZSBiaXRzIGFyZSBpZ25vcmVkIGJ5IHBpcGUgRURQIHNpbmNlIGl0IGNhbiBv bmx5IGNvbm5lY3QgdG8gRERJIEEgKi8KPiAgI2RlZmluZSAgVFJBTlNfRERJX1BPUlRfTUFTSwkJ KDcgPDwgMjgpCj4gKyNkZWZpbmUgIFRHTF9UUkFOU19ERElfUE9SVF9NQVNLCSgweGYgPDwgMjcp Cj4gICNkZWZpbmUgIFRSQU5TX0RESV9QT1JUX1NISUZUCQkyOAo+ICAjZGVmaW5lICBUUkFOU19E RElfU0VMRUNUX1BPUlQoeCkJKCh4KSA8PCAyOCkKPiArI2RlZmluZSAgVEdMX1RSQU5TX0RESV9T RUxFQ1RfUE9SVCh4KQkoKCh4KSArIDEpIDw8IDI3KQo+ICAjZGVmaW5lICBUUkFOU19ERElfUE9S VF9OT05FCQkoMCA8PCAyOCkKPiAgI2RlZmluZSAgVFJBTlNfRERJX01PREVfU0VMRUNUX01BU0sJ KDcgPDwgMjQpCj4gICNkZWZpbmUgIFRSQU5TX0RESV9NT0RFX1NFTEVDVF9IRE1JCSgwIDw8IDI0 KQo+IEBAIC05NTkxLDYgKzk1OTMsOSBAQCBlbnVtIHNrbF9wb3dlcl9nYXRlIHsKPiAgLyogRm9y IGVhY2ggdHJhbnNjb2Rlciwgd2UgbmVlZCB0byBzZWxlY3QgdGhlIGNvcnJlc3BvbmRpbmcgcG9y dCBjbG9jayAqLwo+ICAjZGVmaW5lICBUUkFOU19DTEtfU0VMX0RJU0FCTEVECQkoMHgwIDw8IDI5 KQo+ICAjZGVmaW5lICBUUkFOU19DTEtfU0VMX1BPUlQoeCkJCSgoKHgpICsgMSkgPDwgMjkpCj4g KyNkZWZpbmUgIFRHTF9UUkFOU19DTEtfU0VMX0RJU0FCTEVECSgweDAgPDwgMjgpCj4gKyNkZWZp bmUgIFRHTF9UUkFOU19DTEtfU0VMX1BPUlQoeCkJKCgoeCkgKyAxKSA8PCAyOCkKPiArCj4gIAo+ ICAjZGVmaW5lIENEQ0xLX0ZSRVEJCQlfTU1JTygweDQ2MjAwKQo+ICAKPiAtLSAKPiAyLjIxLjAK Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4