From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources
Date: Thu, 11 Jul 2019 10:41:12 +0300 [thread overview]
Message-ID: <20190711074112.5292-1-simon.ser@intel.com> (raw)
The function was called, but the result was never used. Probably a remnant from
a previous refactoring.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
tests/kms_chamelium.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index b749b5598c1d..321fb16b73bd 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -464,14 +464,11 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
{
igt_display_t *display = &data->display;
igt_output_t *output;
- drmModeRes *res;
drmModeConnector *connector =
chamelium_port_get_connector(data->chamelium, port, false);
enum pipe pipe;
bool found = false;
- igt_require(res = drmModeGetResources(data->drm_fd));
-
/* The chamelium's default EDID has a lot of resolutions, way more then
* we need to test. Additionally the default EDID doesn't support HDMI
* audio.
@@ -501,7 +498,6 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
igt_output_set_pipe(output, pipe);
drmModeFreeConnector(connector);
- drmModeFreeResources(res);
return output;
}
--
2.22.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-07-11 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 7:41 Simon Ser [this message]
2019-07-11 13:34 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: remove unused drmModeGetResources Patchwork
2019-07-11 13:49 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-07-12 4:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711074112.5292-1-simon.ser@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.