From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: DW-DMA: Probe failures on broadwell Date: Thu, 11 Jul 2019 16:12:32 +0300 Message-ID: <20190711131232.GS9224@smile.fi.intel.com> References: <20190709131401.GA9224@smile.fi.intel.com> <20190709132943.GB9224@smile.fi.intel.com> <20190709133448.GC9224@smile.fi.intel.com> <20190709133847.GD9224@smile.fi.intel.com> <20190710164346.GP9224@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9516FF801A4 for ; Thu, 11 Jul 2019 15:12:37 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Curtis Malainey Cc: ALSA development , Ross Zwisler , Fletcher Woodruff , Liam Girdwood , dmaengine@vger.kernel.org, Pierre-louis Bossart List-Id: alsa-devel@alsa-project.org On Wed, Jul 10, 2019 at 02:24:48PM -0700, Curtis Malainey wrote: > On Wed, Jul 10, 2019 at 9:43 AM Andy Shevchenko > wrote: > > On Tue, Jul 09, 2019 at 12:27:49PM -0700, Curtis Malainey wrote: > > > Thanks for the information, we are running a 4.14 kernel so we don't > > > have the idma32 driver, I will see if I can backport it and report > > > back if the fix works. > > > > Driver is supporting iDMA 32-bit in v4.14 AFAICS. > > The missed stuff is a split and some fixes here and there. > > Here is the list of patches I have in a range v4.14..v5.2 > > (I deliberately dropped the insignificant ones) > > > > 934891b0a16c dmaengine: dw: Don't pollute CTL_LO on iDMA 32-bit > > 91f0ff883e9a dmaengine: dw: Reset DRAIN bit when resume the channel > > 69da8be90d5e dmaengine: dw: Split DW and iDMA 32-bit operations > > 87fe9ae84d7b dmaengine: dw: Add missed multi-block support for iDMA 32-bit > > ffe843b18211 dmaengine: dw: Fix FIFO size for Intel Merrifield > > 7b0c03ecc42f dmaengine: dw-dmac: implement dma protection control setting > > > > For me sounds like fairly easy to backport. > > > I got the code integrated, and ran some tests. The test device > regularly hits a BUG_ON in the dw/core.c, debug is turned on in dw > core I see. We need ASoC guys to shed a light here. I don't know that part at all. Only last suggestion I have is to try remove multi-block setting from the platform data (it will be emulated in software if needed). But I don't believe the DMA for audio has no such feature enabled. > We have only been able to consistently reproduce the DMA boot issue on > our original code consistently on 1 device and sporadically on another > handful of devices. > When the device did finally booted after 2-3 device crashes the device > failed to load the DSP. Yeah, it has something to do with this firmware loader code... > [ 3.709573] sst-acpi INT3438:00: DesignWare DMA Controller, 8 channels > [ 3.959027] haswell-pcm-audio haswell-pcm-audio: error: audio DSP > boot timeout IPCD 0x0 IPCX 0x0 > [ 3.970336] bdw-rt5677 bdw-rt5677: ASoC: failed to init link System PCM -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682E6C74A35 for ; Thu, 11 Jul 2019 13:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4763B20872 for ; Thu, 11 Jul 2019 13:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728505AbfGKNMg (ORCPT ); Thu, 11 Jul 2019 09:12:36 -0400 Received: from mga02.intel.com ([134.134.136.20]:12567 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbfGKNMf (ORCPT ); Thu, 11 Jul 2019 09:12:35 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 06:12:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,478,1557212400"; d="scan'208";a="186375427" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga001.fm.intel.com with ESMTP; 11 Jul 2019 06:12:33 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hlYsC-0006Wg-5J; Thu, 11 Jul 2019 16:12:32 +0300 Date: Thu, 11 Jul 2019 16:12:32 +0300 From: Andy Shevchenko To: Curtis Malainey Cc: Ross Zwisler , Fletcher Woodruff , dmaengine@vger.kernel.org, ALSA development , Pierre-louis Bossart , Liam Girdwood Subject: Re: DW-DMA: Probe failures on broadwell Message-ID: <20190711131232.GS9224@smile.fi.intel.com> References: <20190709131401.GA9224@smile.fi.intel.com> <20190709132943.GB9224@smile.fi.intel.com> <20190709133448.GC9224@smile.fi.intel.com> <20190709133847.GD9224@smile.fi.intel.com> <20190710164346.GP9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, Jul 10, 2019 at 02:24:48PM -0700, Curtis Malainey wrote: > On Wed, Jul 10, 2019 at 9:43 AM Andy Shevchenko > wrote: > > On Tue, Jul 09, 2019 at 12:27:49PM -0700, Curtis Malainey wrote: > > > Thanks for the information, we are running a 4.14 kernel so we don't > > > have the idma32 driver, I will see if I can backport it and report > > > back if the fix works. > > > > Driver is supporting iDMA 32-bit in v4.14 AFAICS. > > The missed stuff is a split and some fixes here and there. > > Here is the list of patches I have in a range v4.14..v5.2 > > (I deliberately dropped the insignificant ones) > > > > 934891b0a16c dmaengine: dw: Don't pollute CTL_LO on iDMA 32-bit > > 91f0ff883e9a dmaengine: dw: Reset DRAIN bit when resume the channel > > 69da8be90d5e dmaengine: dw: Split DW and iDMA 32-bit operations > > 87fe9ae84d7b dmaengine: dw: Add missed multi-block support for iDMA 32-bit > > ffe843b18211 dmaengine: dw: Fix FIFO size for Intel Merrifield > > 7b0c03ecc42f dmaengine: dw-dmac: implement dma protection control setting > > > > For me sounds like fairly easy to backport. > > > I got the code integrated, and ran some tests. The test device > regularly hits a BUG_ON in the dw/core.c, debug is turned on in dw > core I see. We need ASoC guys to shed a light here. I don't know that part at all. Only last suggestion I have is to try remove multi-block setting from the platform data (it will be emulated in software if needed). But I don't believe the DMA for audio has no such feature enabled. > We have only been able to consistently reproduce the DMA boot issue on > our original code consistently on 1 device and sporadically on another > handful of devices. > When the device did finally booted after 2-3 device crashes the device > failed to load the DSP. Yeah, it has something to do with this firmware loader code... > [ 3.709573] sst-acpi INT3438:00: DesignWare DMA Controller, 8 channels > [ 3.959027] haswell-pcm-audio haswell-pcm-audio: error: audio DSP > boot timeout IPCD 0x0 IPCX 0x0 > [ 3.970336] bdw-rt5677 bdw-rt5677: ASoC: failed to init link System PCM -- With Best Regards, Andy Shevchenko