From: Sean Paul <sean@poorly.run>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/fb-helper: Include prototype for drm_fb_helper_modinit()
Date: Thu, 11 Jul 2019 11:35:43 -0400 [thread overview]
Message-ID: <20190711153543.GC136584@art_vandelay> (raw)
In-Reply-To: <20190710125143.9965-1-ville.syrjala@linux.intel.com>
On Wed, Jul 10, 2019 at 03:51:39PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Sparse complains:
> drivers/gpu/drm/drm_fb_helper.c:2409:12: warning: symbol 'drm_fb_helper_modinit' was not declared. Should it be static?
>
> Include the header with the correct prototype.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sean Paul <sean@poorly.run>
> ---
> drivers/gpu/drm/drm_fb_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index a7ba5b4902d6..b75ae8555baf 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -46,6 +46,7 @@
> #include <drm/drm_print.h>
> #include <drm/drm_vblank.h>
>
> +#include "drm_crtc_helper_internal.h"
> #include "drm_internal.h"
>
> static bool drm_fbdev_emulation = true;
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-07-11 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 12:51 [PATCH 1/5] drm/fb-helper: Include prototype for drm_fb_helper_modinit() Ville Syrjala
2019-07-10 12:51 ` [PATCH 2/5] drm/dsc: Fix bogus cpu_to_be16() usage Ville Syrjala
2019-07-11 15:36 ` Sean Paul
2019-07-10 12:51 ` [PATCH 3/5] drm: Include prototype for drm_need_swiotlb() Ville Syrjala
2019-07-11 15:37 ` Sean Paul
2019-07-10 12:51 ` [PATCH 4/5] drm/syncobj: Include the prototype for drm_timeout_abs_to_jiffies() Ville Syrjala
2019-07-11 15:39 ` Sean Paul
2019-07-11 16:32 ` Sam Ravnborg
2019-07-10 12:51 ` [PATCH 5/5] drm: Fix return type of crc .poll() Ville Syrjala
2019-07-11 15:40 ` Sean Paul
2019-07-11 15:35 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711153543.GC136584@art_vandelay \
--to=sean@poorly.run \
--cc=dri-devel@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.