All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Joe Slater <joe.slater@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] libtool: allow for use of reproducible_build bbclass
Date: Thu, 11 Jul 2019 23:44:24 +0300	[thread overview]
Message-ID: <20190711204424.GA2092@localhost> (raw)
In-Reply-To: <20190711202739.131168-1-joe.slater@windriver.com>

On Thu, Jul 11, 2019 at 01:27:39PM -0700, Joe Slater wrote:
> In a reproducible build environment, do not put the build host
> name into libtool.
>...
> +Upstream-Status: Inappropriate [embedded specific]
>...

This is not specific to embedded.

> +--- a/m4/libtool.m4
> ++++ b/m4/libtool.m4
> +@@ -728,7 +728,17 @@ _LT_CONFIG_SAVE_COMMANDS([
> +     cat <<_LT_EOF >> "$cfgfile"
> + #! $SHELL
> + # Generated automatically by $as_me ($PACKAGE) $VERSION
> ++_LT_EOF
> ++    if test -n "${SOURCE_DATE_EPOCH}"; then
> ++        cat <<_LT_EOF >> "$cfgfile"
> ++# Libtool was configured for a reproducible build: ${SOURCE_DATE_EPOCH}
> ++_LT_EOF
> ++    else
> ++        cat <<_LT_EOF >> "$cfgfile"
> + # Libtool was configured on host `(hostname || uname -n) 2>/dev/null | sed 1q`:
> ++_LT_EOF
> ++    fi
> ++    cat <<_LT_EOF >> "$cfgfile"
> + # NOTE: Changes made to this file will be lost: look at ltmain.sh.
> + 
>...

The Debian patch for the same purpose simply removes the problematic 
line - a comment with the build host was anyways not important information.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  reply	other threads:[~2019-07-11 20:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 20:27 [PATCH 1/1] libtool: allow for use of reproducible_build bbclass Joe Slater
2019-07-11 20:44 ` Adrian Bunk [this message]
2019-07-11 21:55   ` Burton, Ross
2019-07-12  1:51     ` Slater, Joseph
2019-07-12  6:30       ` Adrian Bunk
2019-07-12  8:33         ` Burton, Ross
2019-07-12  9:19           ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190711204424.GA2092@localhost \
    --to=bunk@stusta.de \
    --cc=joe.slater@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.