From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH rfc v2 00/10] nvme-cli: nvmf auto-connect scripts
Date: Thu, 11 Jul 2019 17:31:30 -0700 [thread overview]
Message-ID: <20190712003140.16221-1-jsmart2021@gmail.com> (raw)
This posting is a combination of the nvme-fc auto-connect scripts
posted by Hannes, the RFC from Sagi to allow auto-connect for
persistent discovery controllers that send AENs, and the RFC that
I posted addressing comments. It does not contain the code that
handles the persistent discovery controller AEN and generates the
event.
The auto-connect scripts are now commonized with the exception
of the nvme-fc boot connections service. It's expected that both
the persistent discovery controllers and nvme-fc can post the same
udev event. Whenever the discovery aen generates an event, the
new --device=<name> argument will be used to identify the persistent
discovery controller. When --device is used, the other connect
attributes will be specified, set to the values of the discovery
controller, and will be used by the cli to validate the device is
who it should be or a new discovery controller will be created.
When nvme-fc generates it's events, it will specify --device=none
and specify the discovery controller addressing arguments. If a
persistent discovery controller exists on nvme-fc, will do nothing
special and AEN's from it will follow the --device=<name> syntax.
The udev event handler supports both the new event to be used
by discovery controllers as well as the existing nvme-fc transport
event. The nvme-fc transport will be migrated to issue the new
event syntax. The udev script will continue to support the older
style nvme-fc event info in case the cli is running against an
older kernel.
v2:
Addressed a couple of comments from Minwoo Im
Break device arg extension into multiple patches
Slight tweaks to parse routine
Add reviewed-by's
James Smart (8):
nvme-cli: ignore arguments that pass in "none"
nvme-cli: allow discover to address discovery controller by persistent
name
nvme-cli: Refactor to create a get_nvme_ctrl_info routine
nvme-cli: extend ctrl_list_item for connect attributes
nvme-cli: Add routine to compare ctrl_list_item to connect args
nvme-cli: Add routine to search for controller with specific
attributes
nvme-cli: Expand --device argument processing
nvme-cli: nvmf auto-connect scripts
Sagi Grimberg (2):
nvme-cli: support persistent connections to a discovery controller
nvme-cli: add --quiet option
Makefile | 16 +-
fabrics.c | 117 +++++++++---
fabrics.h | 2 +
nvme.c | 228 +++++++++++++++++++----
nvme.h | 22 +++
nvme.spec.in | 9 +
nvmf-autoconnect/70-nvmf-autoconnect.conf | 1 +
nvmf-autoconnect/70-nvmf-autoconnect.rules | 18 ++
nvmf-autoconnect/nvmefc-boot-connections.service | 9 +
nvmf-autoconnect/nvmf-connect.target | 2 +
nvmf-autoconnect/nvmf-connect at .service | 14 ++
11 files changed, 381 insertions(+), 57 deletions(-)
create mode 100644 nvmf-autoconnect/70-nvmf-autoconnect.conf
create mode 100644 nvmf-autoconnect/70-nvmf-autoconnect.rules
create mode 100644 nvmf-autoconnect/nvmefc-boot-connections.service
create mode 100644 nvmf-autoconnect/nvmf-connect.target
create mode 100644 nvmf-autoconnect/nvmf-connect at .service
--
2.13.7
next reply other threads:[~2019-07-12 0:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 0:31 James Smart [this message]
2019-07-12 0:31 ` [PATCH rfc v2 01/10] nvme-cli: ignore arguments that pass in "none" James Smart
2019-07-12 0:31 ` [PATCH rfc v2 02/10] nvme-cli: support persistent connections to a discovery controller James Smart
2019-07-12 0:31 ` [PATCH rfc v2 03/10] nvme-cli: allow discover to address discovery controller by persistent name James Smart
2019-07-12 1:34 ` Minwoo Im
2019-07-12 12:41 ` Hannes Reinecke
2019-07-12 16:37 ` Sagi Grimberg
2019-07-12 0:31 ` [PATCH rfc v2 04/10] nvme-cli: Refactor to create a get_nvme_ctrl_info routine James Smart
2019-07-12 0:50 ` Sagi Grimberg
2019-07-12 6:20 ` Hannes Reinecke
2019-07-12 0:31 ` [PATCH rfc v2 05/10] nvme-cli: extend ctrl_list_item for connect attributes James Smart
2019-07-12 0:47 ` Sagi Grimberg
2019-07-16 0:11 ` James Smart
2019-07-16 1:13 ` Sagi Grimberg
2019-07-12 6:24 ` Hannes Reinecke
2019-07-12 0:31 ` [PATCH rfc v2 06/10] nvme-cli: Add routine to compare ctrl_list_item to connect args James Smart
2019-07-12 0:49 ` Sagi Grimberg
2019-07-12 6:25 ` Hannes Reinecke
2019-07-12 0:31 ` [PATCH rfc v2 07/10] nvme-cli: Add routine to search for controller with specific attributes James Smart
2019-07-12 0:50 ` Sagi Grimberg
2019-07-12 6:28 ` Hannes Reinecke
2019-07-12 0:31 ` [PATCH rfc v2 08/10] nvme-cli: Expand --device argument processing James Smart
2019-07-12 0:51 ` Sagi Grimberg
2019-07-12 14:10 ` Hannes Reinecke
2019-07-12 0:31 ` [PATCH rfc v2 09/10] nvme-cli: add --quiet option James Smart
2019-07-12 17:35 ` Sagi Grimberg
2019-07-14 14:49 ` James Smart
2019-07-15 23:34 ` James Smart
2019-07-12 0:31 ` [PATCH rfc v2 10/10] nvme-cli: nvmf auto-connect scripts James Smart
2019-07-12 0:42 ` Sagi Grimberg
2019-07-12 17:26 ` Sagi Grimberg
2019-07-14 14:47 ` James Smart
2019-07-15 17:20 ` Sagi Grimberg
2019-07-12 17:55 ` Sagi Grimberg
2019-07-14 14:49 ` James Smart
2019-07-12 17:58 ` Sagi Grimberg
2019-07-14 14:57 ` James Smart
2019-07-15 17:21 ` Sagi Grimberg
2019-07-15 19:04 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712003140.16221-1-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.