From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Ye Xiaolong" <xiaolong.ye@intel.com>,
"Július Milan" <jmilan.dev@gmail.com>,
dev@dpdk.org, qi.z.zhang@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
Date: Fri, 12 Jul 2019 08:21:04 -0700 [thread overview]
Message-ID: <20190712082104.1d35dfe7@hermes.lan> (raw)
In-Reply-To: <b3f5a056-ef99-9275-7cd7-e26c71b716eb@intel.com>
On Fri, 12 Jul 2019 16:01:39 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 7/12/2019 4:43 PM, Ye Xiaolong wrote:
> > Hi,
> >
> > Thanks for the patch.
> >
> > On 07/12, Július Milan wrote:
> >> Procedure xdp_get_channels_info was returning error code -1 in case of
> >> ioctl command SIOCETHTOOL was not supported. This patch sets return
> >> value back to 0 as it is valid case.
> >>
> >> Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue")
> >>
> >> Signed-off-by: Július Milan <jmilan.dev@gmail.com>
> >
> >
> > Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
The patch was broken. It would not set channel values correctly
next prev parent reply other threads:[~2019-07-12 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 7:55 [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value Július Milan
2019-07-12 15:10 ` Stephen Hemminger
2019-07-12 15:35 ` Ferruh Yigit
2019-07-12 15:48 ` Stephen Hemminger
2019-07-12 16:07 ` Ferruh Yigit
2019-07-12 15:43 ` Ye Xiaolong
2019-07-12 15:01 ` Ferruh Yigit
2019-07-12 15:21 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-12 7:40 Július Milan
2019-07-12 15:09 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712082104.1d35dfe7@hermes.lan \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jmilan.dev@gmail.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.