From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-797-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Fri, 12 Jul 2019 11:01:41 +0200 From: Cornelia Huck Message-ID: <20190712110141.072c1365.cohuck@redhat.com> In-Reply-To: <20190710183212.29420-5-dgilbert@redhat.com> References: <20190710183212.29420-1-dgilbert@redhat.com> <20190710183212.29420-5-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [virtio-comment] Re: [PATCH v6 4/5] shared memory: Define PCI capability To: "Dr. David Alan Gilbert (git)" Cc: virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, stefanha@redhat.com, vgoyal@redhat.com List-ID: On Wed, 10 Jul 2019 19:32:11 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Define the PCI capability used for enumerating shared memory regions. > > Signed-off-by: Dr. David Alan Gilbert > --- > content.tex | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > (...) > +\devicenormative{\paragraph}{Device-specific configuration}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Shared memory capability} Sorry about not noticing that before, but doesn't that need to be referenced in the conformance section somewhere? > + > +The region defined by the combination of the \field {cap.offset}, > +\field {cap.offset_hi}, and \field {cap.length}, \field > +{cap.length_hi} fields MUST be contained within the declared bar. > + > +The \field{cap.id} MUST be unique for any one device instance. > + > \subsubsection{PCI configuration access capability}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / PCI configuration access capability} > > The VIRTIO_PCI_CAP_PCI_CFG capability Otherwise, looks good. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/