From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D50AC742BB for ; Fri, 12 Jul 2019 12:06:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54D5A21019 for ; Fri, 12 Jul 2019 12:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="2QOMxlXA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54D5A21019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hluJy-0003Iy-U1; Fri, 12 Jul 2019 12:06:38 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hluJx-0003IL-Jx for xen-devel@lists.xenproject.org; Fri, 12 Jul 2019 12:06:37 +0000 X-Inumbo-ID: 7e73f97d-a49d-11e9-8980-bc764e045a96 Received: from merlin.infradead.org (unknown [2001:8b0:10b:1231::1]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 7e73f97d-a49d-11e9-8980-bc764e045a96; Fri, 12 Jul 2019 12:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ntU8oMPY07ayUBkHvLSDuYCv3bfOAchf1eGcoqpdijs=; b=2QOMxlXA+8126DIzk43azdjz/ HTxF5vVgRNoK7eXeV7hS7V1jAf9WCS4q5WVvukltI89jL/68fcRWkkChom0D0Qs+ySTAPkDKhAcMW KIkwVCJddWmGDBwJEK/alumUxLK56Wp69kd2oqoMRl6rDT5yLxTGmVWGBe3tzhytayu293pbe063L XvB/wtMNFB/+jRyFzmVKAw4Evgb2W+hew33DVW73HwjR5X4oDsI19z5ZJYTqT51PkP3owlZFnQG7m Df0O4cQXW6b1je3YygrtUIK9fFrflY8grdrrsB/d5uUX2BncLqs+0dqdGgY/UJB0FZP4ZUUQnTGWh ZwFO7rzKQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hluJn-0004ys-JF; Fri, 12 Jul 2019 12:06:27 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2C84620A4087D; Fri, 12 Jul 2019 14:06:26 +0200 (CEST) Date: Fri, 12 Jul 2019 14:06:26 +0200 From: Peter Zijlstra To: Zhenzhong Duan Message-ID: <20190712120626.GW3402@hirez.programming.kicks-ass.net> References: <1562832921-20831-1-git-send-email-zhenzhong.duan@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1562832921-20831-1-git-send-email-zhenzhong.duan@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Xen-devel] [PATCH v2] xen/pv: Fix a boot up hang revealed by int3 self test X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , x86@kernel.org, linux-kernel@vger.kernel.org, srinivas.eeda@oracle.com, Ingo Molnar , Borislav Petkov , Andy Lutomirski , xen-devel@lists.xenproject.org, Boris Ostrovsky , Thomas Gleixner Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gVGh1LCBKdWwgMTEsIDIwMTkgYXQgMDQ6MTU6MjFQTSArMDgwMCwgWmhlbnpob25nIER1YW4g d3JvdGU6Cj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3hlbi9lbmxpZ2h0ZW5fcHYuYyBiL2FyY2gv eDg2L3hlbi9lbmxpZ2h0ZW5fcHYuYwo+IGluZGV4IDQ3MjJiYTIuLjIxMzhkNjkgMTAwNjQ0Cj4g LS0tIGEvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jCj4gKysrIGIvYXJjaC94ODYveGVuL2Vu bGlnaHRlbl9wdi5jCj4gQEAgLTU5Niw3ICs1OTYsNyBAQCBzdHJ1Y3QgdHJhcF9hcnJheV9lbnRy eSB7Cj4gIAo+ICBzdGF0aWMgc3RydWN0IHRyYXBfYXJyYXlfZW50cnkgdHJhcF9hcnJheVtdID0g ewo+ICAJeyBkZWJ1ZywgICAgICAgICAgICAgICAgICAgICAgIHhlbl94ZW5kZWJ1ZywgICAgICAg ICAgICAgICAgICAgIHRydWUgfSwKPiAtCXsgaW50MywgICAgICAgICAgICAgICAgICAgICAgICB4 ZW5feGVuaW50MywgICAgICAgICAgICAgICAgICAgICB0cnVlIH0sCj4gKwl7IGludDMsICAgICAg ICAgICAgICAgICAgICAgICAgeGVuX2ludDMsICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSB9 LAo+ICAJeyBkb3VibGVfZmF1bHQsICAgICAgICAgICAgICAgIHhlbl9kb3VibGVfZmF1bHQsICAg ICAgICAgICAgICAgIHRydWUgfSwKPiAgI2lmZGVmIENPTkZJR19YODZfTUNFCj4gIAl7IG1hY2hp bmVfY2hlY2ssICAgICAgICAgICAgICAgeGVuX21hY2hpbmVfY2hlY2ssICAgICAgICAgICAgICAg dHJ1ZSB9LAoKSSdtIGNvbmZ1c2VkIG9uIHRoZSBwdXJwb3NlIG9mIHRyYXBfYXJyYXlbXSwgY291 bGQgeW91IGVsdWNpZGF0ZSBtZT8KClRoZSBzb2xlIHVzZXIgc2VlbXMgdG8gYmUgZ2V0X3RyYXBf YWRkcigpIGFuZCB0aGF0IHRhbGtzIGFib3V0IElTVHMsIGJ1dAojQlAgaXNuJ3QgYW4gSVNUIGFu eW1vcmUsIHNvIHdoeSBkb2VzIGl0IGhhdmUgaXN0X29rYXk9dHJ1ZT8KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK WGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27FF0C742B9 for ; Fri, 12 Jul 2019 12:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6E3521019 for ; Fri, 12 Jul 2019 12:06:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="2QOMxlXA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbfGLMGq (ORCPT ); Fri, 12 Jul 2019 08:06:46 -0400 Received: from merlin.infradead.org ([205.233.59.134]:33508 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbfGLMGl (ORCPT ); Fri, 12 Jul 2019 08:06:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ntU8oMPY07ayUBkHvLSDuYCv3bfOAchf1eGcoqpdijs=; b=2QOMxlXA+8126DIzk43azdjz/ HTxF5vVgRNoK7eXeV7hS7V1jAf9WCS4q5WVvukltI89jL/68fcRWkkChom0D0Qs+ySTAPkDKhAcMW KIkwVCJddWmGDBwJEK/alumUxLK56Wp69kd2oqoMRl6rDT5yLxTGmVWGBe3tzhytayu293pbe063L XvB/wtMNFB/+jRyFzmVKAw4Evgb2W+hew33DVW73HwjR5X4oDsI19z5ZJYTqT51PkP3owlZFnQG7m Df0O4cQXW6b1je3YygrtUIK9fFrflY8grdrrsB/d5uUX2BncLqs+0dqdGgY/UJB0FZP4ZUUQnTGWh ZwFO7rzKQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hluJn-0004ys-JF; Fri, 12 Jul 2019 12:06:27 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2C84620A4087D; Fri, 12 Jul 2019 14:06:26 +0200 (CEST) Date: Fri, 12 Jul 2019 14:06:26 +0200 From: Peter Zijlstra To: Zhenzhong Duan Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, srinivas.eeda@oracle.com, Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov Subject: Re: [PATCH v2] xen/pv: Fix a boot up hang revealed by int3 self test Message-ID: <20190712120626.GW3402@hirez.programming.kicks-ass.net> References: <1562832921-20831-1-git-send-email-zhenzhong.duan@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562832921-20831-1-git-send-email-zhenzhong.duan@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 11, 2019 at 04:15:21PM +0800, Zhenzhong Duan wrote: > diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c > index 4722ba2..2138d69 100644 > --- a/arch/x86/xen/enlighten_pv.c > +++ b/arch/x86/xen/enlighten_pv.c > @@ -596,7 +596,7 @@ struct trap_array_entry { > > static struct trap_array_entry trap_array[] = { > { debug, xen_xendebug, true }, > - { int3, xen_xenint3, true }, > + { int3, xen_int3, true }, > { double_fault, xen_double_fault, true }, > #ifdef CONFIG_X86_MCE > { machine_check, xen_machine_check, true }, I'm confused on the purpose of trap_array[], could you elucidate me? The sole user seems to be get_trap_addr() and that talks about ISTs, but #BP isn't an IST anymore, so why does it have ist_okay=true?