From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH] drm/i915: Revert "drm/i915: Enable PSR2 by default"
Date: Fri, 12 Jul 2019 05:13:55 -0700 [thread overview]
Message-ID: <20190712121355.GF12992@intel.com> (raw)
In-Reply-To: <156284329225.12757.17426687065171875375@skylake-alporthouse-com>
On Thu, Jul 11, 2019 at 12:08:12PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2019-07-11 12:02:01)
> > On Thu, Jul 11, 2019 at 10:22:54AM +0100, Chris Wilson wrote:
> > > Multiple users are reporting black screens upon boot, after resume, or
> > > frozen after a short period of idleness. A black screen on boot is a
> > > critical issue so disable psr2 again until resolved.
> > >
> > > This reverts commit 8f6e87d6d561f10cfa48a687345512419839b6d8.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111088
> >
> > I agree it is critical, but unfortunately this revert won't solve the issue.
> >
> > [ 1.954886] [drm:intel_psr_init_dpcd [i915]] eDP panel supports PSR version 1
> > [ 2.003686] [drm:intel_psr_enable_locked [i915]] Enabling PSR1
> >
> > Users are claiming the regression is only on 5.2 with 5.1 working well
> > and PSR1 is enabled by default since 5.0.
>
> Hmm, which panels are psr2 and is it being accurately reported?
yes, this part of detection is pretty reliable.
I'd expect PSR2 only on brand new panels
>
> If you suspect psr1, just revert both for now.
I'm hesitating on the revert because psr worked find for 5.0 and 5.1
and even on the current issue the reproducibility is really low
plus the fact that Jose is on top of that working right now.
but yeap, if more issues start to pop up and time passing by we
will have no choice again.
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-12 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 9:22 [PATCH] drm/i915: Revert "drm/i915: Enable PSR2 by default" Chris Wilson
2019-07-11 11:02 ` [Intel-gfx] " Rodrigo Vivi
2019-07-11 11:08 ` Chris Wilson
2019-07-12 12:13 ` Rodrigo Vivi [this message]
2019-07-11 15:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-07-11 15:21 ` Chris Wilson
2019-07-11 19:43 ` Souza, Jose
2019-07-12 10:44 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712121355.GF12992@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.