From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFACC742BA for ; Fri, 12 Jul 2019 12:19:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9553621670 for ; Fri, 12 Jul 2019 12:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562933994; bh=Y43JDGXhtIcmWmFTT0C/gmZWEA5mOx/0fHPejTn+M4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fsXjoXm7affrPHnWU/9/dHizd0iJaXrzFPQpNhRK3TpSTr0kJDX6cYWMuL2YA95i0 B6FBz8QMwAJZ+yhd+wEKZleNvbHcU7hO6fM1QYrCyUFPAKrBgNbYaYNTSPh8eYsQBG XMFj177ug4tP99ufu484jyf3MOXZOc0wxyJj2YyU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbfGLMTx (ORCPT ); Fri, 12 Jul 2019 08:19:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:52638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727017AbfGLMTt (ORCPT ); Fri, 12 Jul 2019 08:19:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2761208E4; Fri, 12 Jul 2019 12:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562933988; bh=Y43JDGXhtIcmWmFTT0C/gmZWEA5mOx/0fHPejTn+M4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T1iCB6ncBylm/PUWI9218CQHbwRl2RX4s6GxtrQlreRiykLltqOJsLQbDgW1Zw6+S Gy9DnUhfuY8VoJhVjfIaXdvsO38H24jfUDV7iKHJhWXqeWI5E7mlCwEq3PNdYB0PJB xe6Yl7y4P4U0uMpuSt9B7I3TPYg7Tz/wYiuEOq40= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Pierre-Louis Bossart , Vinod Koul , Sasha Levin Subject: [PATCH 4.19 10/91] soundwire: stream: fix out of boundary access on port properties Date: Fri, 12 Jul 2019 14:18:13 +0200 Message-Id: <20190712121621.966578722@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190712121621.422224300@linuxfoundation.org> References: <20190712121621.422224300@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 03ecad90d3798be11b033248bbd4bbff4425a1c7 ] Assigning local iterator to array element and using it again for indexing would cross the array boundary. Fix this by directly referring array element without using the local variable. Signed-off-by: Srinivas Kandagatla Acked-by: Pierre-Louis Bossart Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/stream.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index e5c7e1ef6318..907a548645b7 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -1236,9 +1236,7 @@ struct sdw_dpn_prop *sdw_get_slave_dpn_prop(struct sdw_slave *slave, } for (i = 0; i < num_ports; i++) { - dpn_prop = &dpn_prop[i]; - - if (dpn_prop->num == port_num) + if (dpn_prop[i].num == port_num) return &dpn_prop[i]; } -- 2.20.1