From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7900FC742B9 for ; Fri, 12 Jul 2019 12:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F0A120645 for ; Fri, 12 Jul 2019 12:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562934922; bh=QRsSF+WCZ0+JMAzHJH/vuxQnavogD9WLbjsinyx27Ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Y9lHiF+OFuDlemaOWy52l2APXurBySWdG5Fo/KqKLWbidM/UK2n+KUjyeO3SGBC2p 43dDuNCXFzsQYPX++p8C7mMaYFWF14fc4+/UsmZpgkTZIvjnLvwIr4RaROC2WpQ4jc F+M70XAmCVipIK+anyi/bi7HBYBdjpGfbzIQa6ug= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729782AbfGLMes (ORCPT ); Fri, 12 Jul 2019 08:34:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:54784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729776AbfGLMen (ORCPT ); Fri, 12 Jul 2019 08:34:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2EAA20645; Fri, 12 Jul 2019 12:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562934882; bh=QRsSF+WCZ0+JMAzHJH/vuxQnavogD9WLbjsinyx27Ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2JkX3/k44K3G+L6RLPO3oxjmKeY6GvRuhCy061ATi5XXImPZSL08huRt4AGt4JPFb Jagh427nZadsJR/lLpDluJ/KA+hFQWsM+4RFHjvPpsl76aGPk9xeEIkNEwdALtqIwT WdPMOxFNFeLsAS5we6Pcu8ezMlLjhWit+jl9jInc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mathieu Poirier Subject: [PATCH 5.2 45/61] coresight: Potential uninitialized variable in probe() Date: Fri, 12 Jul 2019 14:19:58 +0200 Message-Id: <20190712121623.044961135@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190712121620.632595223@linuxfoundation.org> References: <20190712121620.632595223@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit 0530ef6b41e80c5cc979e0e50682302161edb6b7 upstream. The "drvdata->atclk" clock is optional, but if it gets set to an error pointer then we're accidentally return an uninitialized variable instead of success. Fixes: 78e6427b4e7b ("coresight: funnel: Support static funnel") Signed-off-by: Dan Carpenter Signed-off-by: Mathieu Poirier Cc: stable Link: https://lore.kernel.org/r/20190620221237.3536-6-mathieu.poirier@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/hwtracing/coresight/coresight-funnel.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -241,6 +241,7 @@ static int funnel_probe(struct device *d } pm_runtime_put(dev); + ret = 0; out_disable_clk: if (ret && !IS_ERR_OR_NULL(drvdata->atclk))