From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH] nvmet-file: fix nvmet_file_flush() always returning an error
Date: Sat, 13 Jul 2019 09:26:03 +0200 [thread overview]
Message-ID: <20190713072603.GA17589@lst.de> (raw)
In-Reply-To: <20190712224207.22061-1-logang@deltatee.com>
On Fri, Jul 12, 2019 at 04:42:07PM -0600, Logan Gunthorpe wrote:
> errno_to_nvme_status() doesn't take into account the case
> when errno=0, all other use cases only call it if there is actually
> an error.
Might it make more sense to handle 0 in errno_to_nvme_status to avoid
future problems like this one as well? That would also match the
similar blk_to_nvme_status function better.
next prev parent reply other threads:[~2019-07-13 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 22:42 [PATCH] nvmet-file: fix nvmet_file_flush() always returning an error Logan Gunthorpe
2019-07-12 23:03 ` Sagi Grimberg
2019-07-13 7:26 ` Christoph Hellwig [this message]
2019-07-13 20:10 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190713072603.GA17589@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.